Uh oh!
There was an error while loading. Please reload this page.
Revert "implement From<Vec<char>> and From<&'a [char]> for String" - #36685
Merged
Conversation
This reverts commit ac73335.
rust-highfive
commented
Sep 23, 2016
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
Sep 23, 2016
Collaborator
📌 Commit 2e02803 has been approved by |
brson
commented
Sep 23, 2016
ContributorAuthor
@bors r=sfackler |
bors
commented
Sep 23, 2016
Collaborator
💡 This pull request was already approved, no need to approve it again.
|
bors
commented
Sep 23, 2016
Collaborator
📌 Commit 2e02803 has been approved by |
Merged
bors
commented
Sep 24, 2016
Collaborator
bors added a commit
that referenced
this pull request
Sep 24, 2016
Revert "implement `From<Vec<char>>` and `From<&'a [char]>` for `String`" This reverts commit ac73335. This is a revert of #35054, which resulted in at least 7 known regressions, reported [here](https://internals.rust-lang.org/t/regression-report-stable-2016-08-16-vs-beta-2016-09-21/4119) and [here](#36352), which will hit stable next week. I think this breakage was somewhat unanticipated, and we did not realize so many crates were broken until this week, so reverting is the conservative thing to do until we figure out how not to cause so much breakage. I've run crater on the revert and did not find any new breakage from the revert. Fixes#36352 cc @pwoolcoc@rust-lang/libs
bors
commented
Sep 24, 2016
Collaborator
pwoolcoc
commented
Sep 26, 2016
:( @brson was there something I should have done before opening the PR in order to avoid this in the first place? |
sfackler
commented
Sep 26, 2016
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ac73335.
This is a revert of #35054, which resulted in at least 7 known regressions, reported here and here, which will hit stable next week.
I think this breakage was somewhat unanticipated, and we did not realize so many crates were broken until this week, so reverting is the conservative thing to do until we figure out how not to cause so much breakage. I've run crater on the revert and did not find any new breakage from the revert.
Fixes#36352
cc @pwoolcoc @rust-lang/libs