Allow supplying an error destination via the compiler driver

[nrc]

Allows replacing stderr with a buffer from the client.

Also, some refactoring around run_compiler.

[rust-highfive]

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

[eddyb]

@bors r+

[bors]

📌 Commit 85743df has been approved by eddyb

[sophiajt]

Failing with:

 Compiling rustc_driver v0.0.0 (file:///build/src/librustc_driver)
error: expected one of `;` or `as`, found `extern`
--> src/librustc_driver/lib.rs:58:1
|
58 | extern crate rustc_llvm as llvm;
| ^^^^^^
error: aborting due to previous error
error: Could not compile `rustc_driver`.
To learn more, run the command again with --verbose.
command did not execute successfully: "/build/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "-j" "2" "--target" "x86_64-unknown-linux-gnu" "--release" "--features" " jemalloc" "--manifest-path" "/build/src/rustc/Cargo.toml"
expected success, got: exit code: 101

[eddyb]

@bors r-

[nrc]

r? @eddyb

[bors]

☔ The latest upstream changes (presumably #36678) made this pull request unmergeable. Please resolve the merge conflicts.

[nrc]

rebased, ping @eddyb for r?

[eddyb]

@bors r+

[bors]

📌 Commit 80d9d80 has been approved by eddyb

[bors]

⌛ Testing commit 80d9d80 with merge a50a754...

[bors]

💔 Test failed - auto-win-gnu-64-opt

[alexcrichton]

@bors: retry

On Tue, Sep 27, 2016 at 7:33 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-64-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-64-opt/builds/5721

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36760 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Iw2m8NFOI9Wf47b8FIRxS-xNToiks5qudHjgaJpZM4KHFBt
.

[bors]

⌛ Testing commit 80d9d80 with merge 476607e...

[nrc]

looks like real test failure

[bors]

💔 Test failed - auto-win-msvc-64-opt-rustbuild

[alexcrichton]

@bors: retry

On Tue, Sep 27, 2016 at 7:59 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/2609

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#36760 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95P6xe5w0HMjJqk9u0HIgpvFSS-xNks5qudf5gaJpZM4KHFBt
.

[bors]

⌛ Testing commit 80d9d80 with merge 6a2f6fc...

[nrc]

@bors r=eddyb

[bors]

📌 Commit e8a4db2 has been approved by eddyb

[bors]

⌛ Testing commit e8a4db2 with merge ae94afc...

[bors]

💔 Test failed - auto-win-msvc-64-opt-rustbuild

[alexcrichton]

Hm I haven't seen that before, but sure does look spurious. Let's see if it actually is!

@bors: r+

[bors]

💡 This pull request was already approved, no need to approve it again.

• This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
• There's another pull request that is currently being tested, blocking this pull request: Bump version to 1.14 #36780

[bors]

📌 Commit e8a4db2 has been approved by alexcrichton

[sophiajt]

@bors retry