std: Stabilize and deprecate APIs for 1.13 by alexcrichton · Pull Request #36815 · rust-lang/rust

alexcrichton · 2016-09-29T00:30:55Z

This commit is intended to be backported to the 1.13 branch, and works with the
following APIs:

Stabilized

i32::checked_abs
i32::wrapping_abs
i32::overflowing_abs
RefCell::try_borrow
RefCell::try_borrow_mut

Deprecated

BinaryHeap::push_pop
BinaryHeap::replace
SipHash13
SipHash24
SipHasher - use DefaultHasher instead in the std::collections::hash_map
module

Closes#28147
Closes#34767
Closes#35057
Closes#35070

rust-highfive · 2016-09-29T00:31:00Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

aturon · 2016-09-29T05:03:26Z

r=me after fixing tidy failure

bors · 2016-09-29T10:56:57Z

☔ The latest upstream changes (presumably #36818) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2016-09-29T16:27:23Z

@bors: r=aturon

bors · 2016-09-29T16:27:24Z

📌 Commit 0cdd570 has been approved by aturon

alexcrichton · 2016-09-29T16:29:25Z

@bors: r=aturon

bors · 2016-09-29T16:29:26Z

📌 Commit 546c052 has been approved by aturon

bors · 2016-09-30T07:10:12Z

⌛ Testing commit 546c052 with merge ce57a05...

bors · 2016-09-30T08:15:49Z

💔 Test failed - auto-win-msvc-64-cargotest

sfackler · 2016-09-30T15:29:35Z

/me shakes fist at #[deny(warnings)]

This type is being deprecated in rust-lang/rust#36815, so allow use of the deprecated type for now. We can fix this later once new APIs have landed.

Allow deprecated use of SipHasher This type is being deprecated in rust-lang/rust#36815, so allow use of the deprecated type for now. We can fix this later once new APIs have landed.

alexcrichton · 2016-09-30T17:13:03Z

@bors: r=aturon

bors · 2016-09-30T17:13:04Z

📌 Commit 7c86a2b has been approved by aturon

bors · 2016-10-01T06:49:02Z

⌛ Testing commit 7c86a2b with merge ec3fc8e...

bors · 2016-10-01T08:19:46Z

💔 Test failed - auto-linux-musl-64-opt

This commit is intended to be backported to the 1.13 branch, and works with the following APIs: Stabilized * `i32::checked_abs` * `i32::wrapping_abs` * `i32::overflowing_abs` * `RefCell::try_borrow` * `RefCell::try_borrow_mut` * `DefaultHasher` * `DefaultHasher::new` * `DefaultHasher::default` Deprecated * `BinaryHeap::push_pop` * `BinaryHeap::replace` * `SipHash13` * `SipHash24` * `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map` module Closesrust-lang#28147Closesrust-lang#34767Closesrust-lang#35057Closesrust-lang#35070

alexcrichton · 2016-10-03T17:34:47Z

@bors: r=aturon

bors · 2016-10-03T17:34:48Z

📌 Commit 10c3134 has been approved by aturon

bors · 2016-10-03T18:00:04Z

⌛ Testing commit 10c3134 with merge 7a26aec...

std: Stabilize and deprecate APIs for 1.13 This commit is intended to be backported to the 1.13 branch, and works with the following APIs: Stabilized * `i32::checked_abs` * `i32::wrapping_abs` * `i32::overflowing_abs` * `RefCell::try_borrow` * `RefCell::try_borrow_mut` Deprecated * `BinaryHeap::push_pop` * `BinaryHeap::replace` * `SipHash13` * `SipHash24` * `SipHasher` - use `DefaultHasher` instead in the `std::collections::hash_map` module Closes#28147Closes#34767Closes#35057Closes#35070

bors · 2016-10-03T22:04:39Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: aturon
Pushing 7a26aec to master...

dead10ck · 2017-02-19T19:58:41Z

Is there any plan to split SipHasher into its own crate, for those who specifically want a stable SipHash hasher?

sfackler · 2017-02-19T20:07:13Z

There is already a sip hash crate.

…

On Sun, Feb 19, 2017 at 11:58 AM Skyler Hawthorne ***@***.***> wrote: Is there any plan to split SipHasher into its own crate, for those who specifically want a stable SipHash hasher? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#36815 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABY2UcnpUwTU86DE5K9YzdXWmt5owYHMks5reJ8BgaJpZM4KJdab> .

dead10ck · 2017-02-19T20:42:12Z

I guess I should clarify: since users of SipHasher have, so far, been using an officially published and maintained SipHash implementation, is the Rust team going to publish and maintain an official SipHash crate in the rust-lang GitHub org? Or is the plan just to let the community fill the gap?

sfackler · 2017-02-19T20:47:24Z

Is there anything lacking/problematic with https://crates.io/crates/siphasher?

dead10ck · 2017-02-19T21:28:02Z

I don't know; I haven't tried it. I just need a stable SipHash implementation, and I'd just like to know how to proceed. If there's going to be an official SipHash crate in the relatively near future, then I'd rather wait for that, but if not, then I can try out the available community crates.

rust-highfive assigned aturon Sep 29, 2016

alexcrichton force-pushed the stabilize-1.13 branch 5 times, most recently from ba3cf9c to 1b3eb49Compare September 29, 2016 03:54

alexcrichton force-pushed the stabilize-1.13 branch 2 times, most recently from c5209c3 to 0cdd570Compare September 29, 2016 16:27

alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Sep 29, 2016

alexcrichton force-pushed the stabilize-1.13 branch from 0cdd570 to 546c052Compare September 29, 2016 16:29

alexcrichton added a commit to alexcrichton/cargo that referenced this pull request Sep 30, 2016
Allow deprecated use of SipHasher
3af7890
This type is being deprecated in rust-lang/rust#36815, so allow use of the deprecated type for now. We can fix this later once new APIs have landed.

alexcrichton mentioned this pull request Sep 30, 2016
Allow deprecated use of SipHasher rust-lang/cargo#3142
Merged

alexcrichton force-pushed the stabilize-1.13 branch from 546c052 to 7c86a2bCompare September 30, 2016 17:12

brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 30, 2016

alexcrichton force-pushed the stabilize-1.13 branch from 7c86a2b to 10c3134Compare October 3, 2016 17:34

bors merged commit 10c3134 into rust-lang:masterOct 3, 2016

bors mentioned this pull request Oct 3, 2016
incr.comp.: Minor refactoring and update to struct ICH test case #36831
Merged

mcarton mentioned this pull request Oct 4, 2016
Remove warning in the latest nightly rust-lang/rust-clippy#1262
Merged

alexcrichton deleted the stabilize-1.13 branch October 6, 2016 18:06

This was referenced Oct 10, 2016
SipHasher::new_with_keys deprecation message is unhelpful/misleading #37070
Closed
No non-deprecated hasher in libcore #37071
Closed

alexcrichton mentioned this pull request Oct 10, 2016
Backporting PRs to beta #37080
Merged

brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 11, 2016

chritchens mentioned this pull request Apr 27, 2017
Use DefaultHasher in place of the deprecated SipHasher rust-bitcoin/rust-secp256k1#11
Merged

Uh oh!

Uh oh!

Conversation

alexcrichton commented Sep 29, 2016

Uh oh!

rust-highfive commented Sep 29, 2016

Uh oh!

aturon commented Sep 29, 2016

Uh oh!

bors commented Sep 29, 2016

Uh oh!

alexcrichton commented Sep 29, 2016

Uh oh!

bors commented Sep 29, 2016

Uh oh!

alexcrichton commented Sep 29, 2016

Uh oh!

bors commented Sep 29, 2016

Uh oh!

bors commented Sep 30, 2016

Uh oh!

bors commented Sep 30, 2016

Uh oh!

sfackler commented Sep 30, 2016

Uh oh!

alexcrichton commented Sep 30, 2016

Uh oh!

bors commented Sep 30, 2016

Uh oh!

bors commented Oct 1, 2016

Uh oh!

bors commented Oct 1, 2016

Uh oh!

alexcrichton commented Oct 3, 2016

Uh oh!

bors commented Oct 3, 2016

Uh oh!

bors commented Oct 3, 2016

Uh oh!

bors commented Oct 3, 2016

Uh oh!

dead10ck commented Feb 19, 2017

Uh oh!

sfackler commented Feb 19, 2017 via email

Uh oh!

dead10ck commented Feb 19, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sfackler commented Feb 19, 2017

Uh oh!

dead10ck commented Feb 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dead10ck commented Feb 19, 2017•
edited
Loading