Minor librustdoc cleanup and refactoring.

[frewsxcv]

No description provided.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[frewsxcv]

r? @GuillaumeGomez

[frewsxcv]

I need a sanity check for 19f6130

Here's the new print function it will use:

rust/src/librustc/hir/print.rs

Lines 273 to 275 in df9fa1a

	pubfnpath_to_string(p:&hir::Path) -> String{
	to_string(|s| s.print_path(p,false,0))
	}

rust/src/librustc/hir/print.rs

Lines 1615 to 1636 in df9fa1a

	fnprint_path(&mutself,
	path:&hir::Path,
	colons_before_params:bool,
	depth:usize)
	-> io::Result<()>{
	self.maybe_print_comment(path.span.lo)?;
	letmut first = !path.global;
	for segment in&path.segments[..path.segments.len() - depth]{
	if first {
	first = false
	}else{
	word(&mutself.s,"::")?
	}
	self.print_name(segment.name)?;
	self.print_path_parameters(&segment.parameters, colons_before_params)?;
	}
	Ok(())
	}

[jseyfried]

r=me modulo comments.

[jseyfried]

Could you make this an implementation of Clean<VariantKind> for hir::VariantData?

[frewsxcv]

d6fb0c8d6a01beab132f1df7832794401ac92a46

[jseyfried]

hir::print::State::print_path begins with self.maybe_print_comment(path.span.lo), which might actually print a comment in this case:

fnf(arg1:(),// Some comment
path::to::TupleStruct(x): path::to::TupleStruct){//^ The `name_from_pat` of this tuple struct pattern might include "// Some comment"}

[frewsxcv]

Do you think I should add an parameter to that function to control whether the comment gets printed or just ditch that commit?

[jseyfried]

I'd probably ditch the commit to be on the safe side since I don't understand the pretty printer, especially in edge cases (e.g. it might emit newlines and indents in long patterns).

[jseyfried]

nit: this can fit on one line

[jseyfried]

nit: this can fit on one line

[jseyfried]

nit: this would be easier for me to read:

iflet clean::VariantItem(Variant{kind:VariantKind::Struct(ref s)}) =
variant.inner{

[jseyfried]

or

iflet clean::VariantItem(Variant{kind:VariantKind::Struct(ref s)}) = variant.inner{

[frewsxcv]

Latest force push removes 19f6130 and makes the suggested style changes.

[jseyfried]

Thanks! @bors r+

[bors]

📌 Commit 35d214a has been approved by jseyfried