Skip to content

stop having identity casts be lexprs - #36942

Merged
bors merged 1 commit into
rust-lang:masterfrom
arielb1:cast-lifetimes
Oct 5, 2016
Merged

stop having identity casts be lexprs#36942
bors merged 1 commit into
rust-lang:masterfrom
arielb1:cast-lifetimes

Conversation

@arielb1

@arielb1arielb1 commented Oct 3, 2016

Copy link
Copy Markdown
Contributor

that made no sense (see test), and was incompatible with borrowck.

Fixes#36936.

beta-nominated since (bad) regression.

r? @eddyb

@arielb1
stop having identity casts be lexprs
c2a0859
that made no sense (see test), and was incompatible with borrowck.
Fixesrust-lang#36936.
@arielb1arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 3, 2016
@eddyb

eddyb commented Oct 3, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 3, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit c2a0859 has been approved by eddyb

@alexcrichton

alexcrichton commented Oct 5, 2016

Copy link
Copy Markdown
Member

@bors: p=1

(fixing a regression)

@bors

bors commented Oct 5, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c2a0859 with merge 165a03d...

bors added a commit that referenced this pull request Oct 5, 2016
@bors
Auto merge of#36942- arielb1:cast-lifetimes, r=eddyb
165a03d
stop having identity casts be lexprs
that made no sense (see test), and was incompatible with borrowck.
Fixes#36936.
beta-nominated since (bad) regression.
r? @eddyb
@bors

bors commented Oct 5, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 165a03d to master...

@bors
bors merged commit c2a0859 into rust-lang:masterOct 5, 2016
@brsonbrson added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2016
@nikomatsakisnikomatsakis added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Oct 11, 2016
@nikomatsakis

nikomatsakis commented Oct 11, 2016

Copy link
Copy Markdown
Contributor

Accepting for beta because small patch, regression.

cc @rust-lang/compiler

@alexcrichtonalexcrichton mentioned this pull request Oct 11, 2016
Merged
@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 11, 2016
@brsonbrson mentioned this pull request Oct 14, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@eddybeddybeddyb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eddybeddyb

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arielb1@eddyb@bors@alexcrichton@nikomatsakis@brson