More refactoring to obey platform abstraction lint by brson · Pull Request #36948 · rust-lang/rust

brson · 2016-10-04T00:25:20Z

The most interesting things here are moving std/sys/common to std/sys_common, and std/num/{f32,f64}.rs to std/{f32,f64}.rs, and adding more documentation to std/lib.rs.

r? @alexcrichton

brson · 2016-10-04T00:27:20Z

This macro is no longer used anywhere.

🎺 ⚰ 🎺

brson · 2016-10-04T00:32:20Z

A lot of this is just general cleanup...

alexcrichton · 2016-10-04T03:48:11Z

src/libstd/num/f64.rs → src/libstd/f64.rs

How dare you!

alexcrichton · 2016-10-04T03:49:11Z

If you're really ambitious, I've been meaning to remove all the cfg_attr here and just leave deny(warnings)

alexcrichton · 2016-10-04T03:50:12Z

I think the ordering here affects the ordering in rustdoc, right? (just confirming you want to change that too)

It does not appear so to me. rustdoc seems to be alphabetizing everything.

alexcrichton · 2016-10-04T03:50:53Z

aww I was hoping we could keep this contained within the sys module

I'll see if I can put it there. I don't recall why I moved it, presumably just because it didn't work with my prefered module declaration order in lib.rs.

alexcrichton · 2016-10-04T03:55:15Z

I think we'll want to always compile in this module. The theory behind this is that we compile the standard library with OS-based TLS (e.g. this module) but then consumers of the standard library can use the "fast TLS". The primary motivation here is OSX 10.6 and 10.7+, where 10.6 has slow TLS only but 10.7 has fast. We could in theory compile a 10.6 standard library but everyone else would have fast TLS.

alexcrichton · 2016-10-04T03:56:41Z

moving std/sys/common to std/sys_common

I kinda liked having everything contained in one nice "sys" directory, but I guess not enough to go against conventions of filesystem hierarchies and module structures.

brson · 2016-10-04T18:07:18Z

Updated to leave os-specific TLS key in with documentation for why, move rtabort back to sys_common.

alexcrichton · 2016-10-04T20:29:02Z

@bors: r+

bors · 2016-10-04T20:29:04Z

📌 Commit ae10558 has been approved by alexcrichton

bors · 2016-10-06T06:48:12Z

⌛ Testing commit ae10558 with merge d3b75bb...

bors · 2016-10-06T17:04:43Z

💥 Test timed out

alexcrichton · 2016-10-06T17:18:56Z

@bors: retry

??

bors · 2016-10-06T23:33:27Z

☔ The latest upstream changes (presumably #37002) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2016-10-10T20:53:30Z

@bors: retry

bors · 2016-10-13T03:40:00Z

🔒 Merge conflict

alexcrichton · 2016-10-31T20:41:45Z

ping @brson (for an update)

Make the directory structure reflect the module structure. I've always found the existing structure confusing.

This makes it dissimilar to how core is structured on disk, but more predictable on its own.

brson · 2016-11-01T17:08:51Z

@bors r+

bors · 2016-11-01T17:08:54Z

📌 Commit 6135cbc has been approved by brson

bors · 2016-11-02T09:57:49Z

⌛ Testing commit 6135cbc with merge fc67cad...

@alexcrichton

More refactoring to obey platform abstraction lint The most interesting things here are moving `std/sys/common` to `std/sys_common`, and `std/num/{f32,f64}.rs` to `std/{f32,f64}.rs`, and adding more documentation to `std/lib.rs`. r? @alexcrichton

bors · 2016-11-02T12:37:32Z

💔 Test failed - auto-win-gnu-64-opt

alexcrichton · 2016-11-02T15:28:02Z

@bors: retry

On Wednesday, November 2, 2016, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-64-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-64-opt/builds/6005
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#36948 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95PUMAp0IYQNuNyPDU8pI9h-DwlSBks5q6IQPgaJpZM4KNL4c
.

bors · 2016-11-02T15:44:38Z

⌛ Testing commit 6135cbc with merge 0ca9967...

@alexcrichton

More refactoring to obey platform abstraction lint The most interesting things here are moving `std/sys/common` to `std/sys_common`, and `std/num/{f32,f64}.rs` to `std/{f32,f64}.rs`, and adding more documentation to `std/lib.rs`. r? @alexcrichton

bors · 2016-11-02T18:57:28Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: brson
Pushing 0ca9967 to master...

rust-highfive assigned alexcrichton Oct 4, 2016

brson commented Oct 4, 2016
View reviewed changes

alexcrichton reviewed Oct 4, 2016
View reviewed changes

brson force-pushed the sys branch from bc4c1d4 to ae10558Compare October 4, 2016 18:06

brson mentioned this pull request Oct 17, 2016
Port libstd to "no operating system" target #37133
Closed

brson added 8 commits November 1, 2016 17:08

std: Move elf TLS to sys::fast_thread_local
5688407

Document reasoning for supporting both fast and OS TLS in the same bin
8b2600d

std: Move a plattform-specific constant to sys::stdio
6d54cd4

std: Move platform-specific code out of libstd/lib.rs
219c018

std: Move platform-specific out of sys_common::util
f3a709d

std: Move sys_common to libstd/sys_common
ca30691
Make the directory structure reflect the module structure. I've always found the existing structure confusing.

Document sys_common and sys
ee71dc5

std: Remove unused test feature
8f5bb1f

brson added 2 commits November 1, 2016 17:08

Clean up and add more comments to libstd/lib.rs
c251884

std: Flatten the num directory to reflect the module layout
6135cbc
This makes it dissimilar to how core is structured on disk, but more predictable on its own.

brson force-pushed the sys branch from ae10558 to 6135cbcCompare November 1, 2016 17:08

bors merged commit 6135cbc into rust-lang:masterNov 2, 2016

Uh oh!

Uh oh!

Conversation

brson commented Oct 4, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brson commented Oct 4, 2016

Uh oh!

alexcrichton commented Oct 4, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Oct 4, 2016

Uh oh!

brson commented Oct 4, 2016

Uh oh!

alexcrichton commented Oct 4, 2016

Uh oh!

bors commented Oct 4, 2016

Uh oh!

bors commented Oct 6, 2016

Uh oh!

bors commented Oct 6, 2016

Uh oh!

alexcrichton commented Oct 6, 2016

Uh oh!

bors commented Oct 6, 2016

Uh oh!

alexcrichton commented Oct 10, 2016

Uh oh!

bors commented Oct 13, 2016

Uh oh!

alexcrichton commented Oct 31, 2016

Uh oh!

brson commented Nov 1, 2016

Uh oh!

bors commented Nov 1, 2016

Uh oh!

bors commented Nov 2, 2016

Uh oh!

bors commented Nov 2, 2016

Uh oh!

alexcrichton commented Nov 2, 2016

Uh oh!

bors commented Nov 2, 2016

Uh oh!

bors commented Nov 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants