Uh oh!
There was an error while loading. Please reload this page.
force i1 booleans to i8 when comparing - #36958
Merged
Merged
Conversation
Work around LLVM bug. cc rust-lang#36856
eddyb
commented
Oct 4, 2016
Contributor
@bors r+ |
bors
commented
Oct 4, 2016
Collaborator
📌 Commit 3e1bd19 has been approved by |
alexcrichton
commented
Oct 5, 2016
Member
@bors: p=1 (fixing a regression) |
bors
commented
Oct 5, 2016
Collaborator
bors
commented
Oct 5, 2016
Collaborator
brson
commented
Oct 5, 2016
Contributor
Nominated for backport. Regression fix (though it's been on stable a long time). |
nikomatsakis
commented
Oct 6, 2016
ContributorAuthor
Backport seems fine to me. This is a really simple patch. |
nikomatsakis
commented
Oct 11, 2016
ContributorAuthor
Accepting for beta because small patch, regression. cc @rust-lang/compiler |
stouset
commented
Oct 20, 2016
Out of curiosity, is there a plan to revert this workaround once the upstream bug is fixed? |
nikomatsakis
commented
Oct 21, 2016
ContributorAuthor
@stouset good question. I have no such plan. It probably makes sense to do, but I don't know an easy way to make sure we don't forget. =) I guess filing a P-medium issue might help or something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work around LLVM bug.
cc #36856
r? @eddyb