Uh oh!
There was an error while loading. Please reload this page.
rewrite checked_{div,rem} to no contain any reference to panics - #37029
Conversation
even without optimizations
rust-highfive
commented
Oct 7, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
alexcrichton
commented
Oct 7, 2016
japaric
commented
Oct 7, 2016
While implementing this. I noticed that |
alexcrichton
commented
Oct 7, 2016
Hm I don't think |
japaric
commented
Oct 7, 2016
@alexcrichton Oh, that makes sense. |
| } else { | ||
| let (a, b) = self.overflowing_div(other); | ||
| if b {None} else {Some(a)} | ||
| Some(unsafe { intrinsics::unchecked_div(self, other) }) |
There was a problem hiding this comment.
Why intrinsic, not wrapping_div?
EDIT: wrapping_div also has references to panic. I was thinking it used unchecked_div o.O.
…=alexcrichton
rewrite checked_{div,rem} to no contain any reference to panics
even without optimizations
r? @alexcrichton
even without optimizations
r? @alexcrichton