Skip to content

llvm: Update LLVM to include fix for pathologic case in its LiveDebugValues pass. - #37030

Merged
bors merged 3 commits into
rust-lang:masterfrom
michaelwoerister:live-debug-values-fix
Oct 10, 2016
Merged

llvm: Update LLVM to include fix for pathologic case in its LiveDebugValues pass.#37030
bors merged 3 commits into
rust-lang:masterfrom
michaelwoerister:live-debug-values-fix

Conversation

@michaelwoerister

@michaelwoeristermichaelwoerister commented Oct 7, 2016

Copy link
Copy Markdown
Member

@michaelwoerister

michaelwoerister commented Oct 7, 2016

Copy link
Copy Markdown
MemberAuthor

Oh, wait, I remembered I need to update something in order not to break the build bots, right? Give me a sec...

@alexcrichton

alexcrichton commented Oct 7, 2016

Copy link
Copy Markdown
Member

Ah yeah we'll want to modify src/rustllvm/llvm-auto-clean-trigger

@alexcrichton

alexcrichton commented Oct 7, 2016

Copy link
Copy Markdown
Member

r=me though

@alexcrichtonalexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 7, 2016
@michaelwoerister

michaelwoerister commented Oct 7, 2016

Copy link
Copy Markdown
MemberAuthor

@bors r=alexcrichton

@bors

bors commented Oct 7, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 7fcc124 has been approved by alexcrichton

@alexcrichton

alexcrichton commented Oct 7, 2016

Copy link
Copy Markdown
Member

@bors: p=1

@bors

bors commented Oct 7, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7fcc124 with merge f6409e0...

@bors

bors commented Oct 8, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-32-opt

@arielb1

arielb1 commented Oct 8, 2016

Copy link
Copy Markdown
Contributor

Don't you also want to incorporate the fix to #36924 here?

@michaelwoerister

michaelwoerister commented Oct 10, 2016

Copy link
Copy Markdown
MemberAuthor

@arielb1 Yes, that seems like a good idea. I'll take care of it.

@michaelwoerister

michaelwoerister commented Oct 10, 2016

Copy link
Copy Markdown
MemberAuthor

I'm currently running make check locally on a branch also containing the SimplifyCFG fix. If that passes, I'll make another PR against the LLVM repo and update this one.

Btw, I have no clue what that test failure above is about. It seems unrelated to changes in LLVM debuginfo generation.

@michaelwoerister

michaelwoerister commented Oct 10, 2016

Copy link
Copy Markdown
MemberAuthor

@bors r=alexcrichton

@alexcrichton I'm assuming, since you merged @arielb1's PR to the LLVM repo, that you are in favor of including that patch with this update...

@bors

bors commented Oct 10, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 7d03bad has been approved by alexcrichton

@michaelwoerister

michaelwoerister commented Oct 10, 2016

Copy link
Copy Markdown
MemberAuthor

@bors p=1

@alexcrichton

alexcrichton commented Oct 10, 2016

Copy link
Copy Markdown
Member

👍

@alexcrichton

alexcrichton commented Oct 10, 2016

Copy link
Copy Markdown
Member

@bors: retry force clean

@bors

bors commented Oct 10, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7d03bad with merge a3bc191...

bors added a commit that referenced this pull request Oct 10, 2016
@bors
Auto merge of#37030- michaelwoerister:live-debug-values-fix, r=alex…
a3bc191
…crichton
llvm: Update LLVM to include fix for pathologic case in its LiveDebugValues pass.
See #36926.
r? @alexcrichton
@bors

bors commented Oct 10, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing a3bc191 to master...

@bors
bors merged commit 7d03bad into rust-lang:masterOct 10, 2016
@nikomatsakis

nikomatsakis commented Oct 11, 2016

Copy link
Copy Markdown
Contributor

Accepting for beta because terrible regression. However, this is bumping LLVM, incorporating the following commits, all of which seem relatively targeted to me.

cc @rust-lang/compiler

@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 11, 2016
@brsonbrson mentioned this pull request Oct 14, 2016
Closed
This was referenced Oct 14, 2016
Merged
Merged
@michaelwoeristermichaelwoerister removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 14, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michaelwoerister@alexcrichton@bors@arielb1@nikomatsakis