Uh oh!
There was an error while loading. Please reload this page.
[beta] Temporary fix for metadata decoding for struct constructors - #37078
Conversation
rust-highfive
commented
Oct 10, 2016
|
alexcrichton
commented
Oct 10, 2016
@petrochenkov to clarify, is this fixed on nightly? |
petrochenkov
commented
Oct 10, 2016
@alexcrichton |
alexcrichton
commented
Oct 10, 2016
Ah ok, we typically avoid backports unless the fix is on nightly (as the master branch has more CI testing right now), so perhaps we could hold off until the fix is on nightly? |
petrochenkov
commented
Oct 10, 2016
Okay, there's no hurry. I'm not sure the nightly fix will be backportable to beta, but let's see. |
alexcrichton
commented
Oct 10, 2016
Hm yeah that's a good point. I figure we can see what it looks like first to ensure it passes tests everywhere and then we can selectively backport. |
Temporary fix for metadata decoding for struct constructors Same as #37078, but for nightly. Ideally, metadata lookup functions should "just work" for constructor ids, but this fixes the issue as well. Fixes#37026 r? @alexcrichton
alexcrichton
commented
Oct 12, 2016
Ok, now that #37095 has landed, it looks like this isn't quite an exact cherry-pick, but @petrochenkov just to confirm that's intended, right? |
petrochenkov
commented
Oct 12, 2016
Exact cherry pick is not possible, unfortunately. #37095 is based on this large commit that exists only on nightly. This PR is the closest approximation. |
alexcrichton
commented
Oct 12, 2016
Ok sounds good to me! To follow the process let's wait for #37095 to get tagged with beta-accepted now (cc @nikomatsakis) |
I'll try to do something better for nightly. Ideally, metadata lookup functions should "just work" for constructor ids.
cc #37026
r? @brson
Backport of #37095