Uh oh!
There was an error while loading. Please reload this page.
Lint against lowercase static mut - #37162
Merged
Merged
Conversation
rust-highfive
commented
Oct 14, 2016
Contributor
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
matkladforce-pushed
the
static-mut-lint
branch
2 times, most recently
from
October 14, 2016 13:22
5147918 to
6f216f6Compare
jseyfried
left a comment
Contributor
There was a problem hiding this comment.
Thanks! r=me with the comment addressed.
| } | ||
| hir::ItemStatic(_, hir::MutMutable, _) => { | ||
| NonUpperCaseGlobals::check_upper_case(cx, "static variable", it.name, it.span); | ||
| } |
Contributor
There was a problem hiding this comment.
I think the above two arms could be merged into a single arm:
hir::ItemStatic(..) => {NonUpperCaseGlobals::check_upper_case(cx,"static variable", it.name, it.span);}jseyfried
commented
Oct 17, 2016
Contributor
@bors r+ |
bors
commented
Oct 17, 2016
Collaborator
📌 Commit 066d62d has been approved by |
bors
commented
Oct 17, 2016
Collaborator
matklad
commented
Oct 17, 2016
ContributorAuthor
This may produce new warnings. Should the relnotes label be applied? |
alexcrichton
commented
Oct 17, 2016
Member
Yeah, let's tag |
bors
commented
Oct 17, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#37145.
Lint for non mut statics was added in #7523, and it explicitly did not cover mut statics. I am not sure why.