Uh oh!
There was an error while loading. Please reload this page.
macros: Future proof #[no_link] - #37247
Merged
Merged
Conversation
jseyfriedforce-pushed
the
future_proof_no_link
branch
from
October 18, 2016 07:32
affcf88 to
bb0b961Comparebors
commented
Oct 19, 2016
Collaborator
☔ The latest upstream changes (presumably #37269) made this pull request unmergeable. Please resolve the merge conflicts. |
jseyfriedforce-pushed
the
future_proof_no_link
branch
from
October 19, 2016 10:05
bb0b961 to
b283aafComparenrc
commented
Oct 21, 2016
Member
@nikomatsakis or @eddyb can we get a crater run for this PR please? r=me with a clean crater run |
Contributor
@bors r=nrc |
bors
commented
Oct 21, 2016
Collaborator
📌 Commit b283aaf has been approved by |
bors
commented
Oct 21, 2016
Collaborator
bors added a commit
that referenced
this pull request
Oct 21, 2016
macros: Future proof `#[no_link]` This PR future proofs `#[no_link]` for macro modularization (cc #35896). First, we resolve all `#[no_link] extern crate`s. `#[no_link]` crates without `#[macro_use]` or `#[macro_reexport]` are not resolved today, this is a [breaking-change]. For example, ```rust ``` Any breakage can be fixed by simply removing the `#[no_link] extern crate`. Second, `#[no_link] extern crate`s will define an empty module in type namespace to eventually allow importing the crate's macros with `use`. This is a [breaking-change], for example: ```rust mod syntax {} //< This becomes a duplicate error. ``` r? @nrc
bors
commented
Oct 21, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR future proofs
#[no_link]for macro modularization (cc #35896).First, we resolve all
#[no_link] extern crates.#[no_link]crates without#[macro_use]or#[macro_reexport]are not resolved today, this is a [breaking-change]. For example,Any breakage can be fixed by simply removing the
#[no_link] extern crate.Second,
#[no_link] extern crates will define an empty module in type namespace to eventually allow importing the crate's macros withuse. This is a [breaking-change], for example:r? @nrc