Uh oh!
There was an error while loading. Please reload this page.
Detect local-rebuild by just the MAJOR.MINOR version - #37273
Merged
Conversation
rust-highfive
commented
Oct 19, 2016
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
Oct 19, 2016
Collaborator
☔ The latest upstream changes (presumably #37269) made this pull request unmergeable. Please resolve the merge conflicts. |
A new point-release shouldn't change any language semantics, so a local stage0 that matches MAJOR.MINOR version should still be considered a local-rebuild as far as `--cfg stageN` features go. e.g. `1.14.0` should be considered a local-rebuild for any `1.14.X`. (Bootstrap keys used to be an issue too, until rust-lang#37265.)
cuviperforce-pushed
the
major-minor-rebuild
branch
from
October 19, 2016 15:22
8e6c905 to
81d9795Comparecuviper
commented
Oct 19, 2016
MemberAuthor
Rebased. |
aturon
commented
Oct 19, 2016
Contributor
alexcrichton
commented
Oct 19, 2016
Member
@bors: r+ |
bors
commented
Oct 19, 2016
Collaborator
📌 Commit 81d9795 has been approved by |
bors
commented
Oct 20, 2016
Collaborator
bors added a commit
that referenced
this pull request
Oct 20, 2016
Detect local-rebuild by just the MAJOR.MINOR version A new point-release shouldn't change any language semantics, so a local stage0 that matches MAJOR.MINOR version should still be considered a local-rebuild as far as `--cfg stageN` features go. e.g. `1.14.0` should be considered a local-rebuild for any `1.14.X`. (Bootstrap keys used to be an issue too, until #37265.)
bors
commented
Oct 20, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new point-release shouldn't change any language semantics, so a local
stage0 that matches MAJOR.MINOR version should still be considered a
local-rebuild as far as
--cfg stageNfeatures go.e.g.
1.14.0should be considered a local-rebuild for any1.14.X.(Bootstrap keys used to be an issue too, until #37265.)