Skip to content

run rustfmt on librustc_driver folder - #37296

Merged
bors merged 1 commit into
rust-lang:masterfrom
srinivasreddy:librustc_driver
Nov 2, 2016
Merged

run rustfmt on librustc_driver folder#37296
bors merged 1 commit into
rust-lang:masterfrom
srinivasreddy:librustc_driver

Conversation

@srinivasreddy

@srinivasreddysrinivasreddy commented Oct 20, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Oct 20, 2016

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@srinivasreddy

srinivasreddy commented Oct 20, 2016

Copy link
Copy Markdown
ContributorAuthor

@nikomatsakis LGTM. What do you think?

@nikomatsakis

nikomatsakis commented Oct 21, 2016

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Oct 23, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37301) made this pull request unmergeable. Please resolve the merge conflicts.

jseyfried
jseyfried reviewed Oct 23, 2016
View reviewed changes
Comment threadsrc/librustc_driver/pretty.rs Outdated

@jseyfriedjseyfriedOct 23, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this formatting confusing and hard to read.

Comment threadsrc/librustc_driver/pretty.rs Outdated

@jseyfriedjseyfriedOct 23, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needless added line break.

Comment threadsrc/librustc_driver/pretty.rs Outdated

@jseyfriedjseyfriedOct 23, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange indent.

Comment threadsrc/librustc_driver/pretty.rs Outdated

@jseyfriedjseyfriedOct 23, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange indent.

Comment threadsrc/librustc_driver/pretty.rs Outdated

@jseyfriedjseyfriedOct 23, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indent (looks like a rustfmt bug).

@nrcnrcOct 25, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-lang/rustfmt#1197

Comment threadsrc/librustc_driver/pretty.rs Outdated

@jseyfriedjseyfriedOct 23, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very strange/confusing.

@srinivasreddy

srinivasreddy commented Oct 25, 2016

Copy link
Copy Markdown
ContributorAuthor

@nikomatsakis rollup pls

@nrc

nrc commented Oct 25, 2016

Copy link
Copy Markdown
Member

I filed an issue for the over-indented match arm. I think all the other issues are already known.

@bors

bors commented Oct 30, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37400) made this pull request unmergeable. Please resolve the merge conflicts.

@nikomatsakis

nikomatsakis commented Oct 31, 2016

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Oct 31, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit f32ce9c has been approved by nikomatsakis

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 1, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#37296- srinivasreddy:librustc_driver, r=ni…
ed96e4f
…komatsakis
run rustfmt on librustc_driver folder
@GuillaumeGomezGuillaumeGomez mentioned this pull request Nov 1, 2016
Merged
bors added a commit that referenced this pull request Nov 2, 2016
@bors
Auto merge of#37514- GuillaumeGomez:rollup, r=GuillaumeGomez
3fba503
Rollup of 7 pull requests
- Successful merges: #36849, #37059, #37296, #37316, #37484, #37485, #37495
- Failed merges:
@bors
bors merged commit f32ce9c into rust-lang:masterNov 2, 2016
@srinivasreddy
srinivasreddy deleted the librustc_driver branch November 2, 2016 06:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@nrcnrcnrc left review comments
@jseyfriedjseyfriedjseyfried left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@nikomatsakisnikomatsakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@srinivasreddy@rust-highfive@nikomatsakis@bors@nrc@jseyfried