Skip to content

Fix $crate-related regressions - #37361

Merged
bors merged 3 commits into
rust-lang:masterfrom
jseyfried:fix_crate_var_regressions
Oct 26, 2016
Merged

Fix $crate-related regressions#37361
bors merged 3 commits into
rust-lang:masterfrom
jseyfried:fix_crate_var_regressions

Conversation

@jseyfried

@jseyfriedjseyfried commented Oct 23, 2016

Copy link
Copy Markdown
Contributor

Fixes#37345, fixes#37357, fixes#37352, and improves the unused_extern_crates lint.
r? @nrc

@jseyfried
jseyfriedforce-pushed the fix_crate_var_regressions branch from 1cf3220 to 9106d21CompareOctober 23, 2016 05:58
This was referenced Oct 23, 2016
Closed
Closed
Closed
@petrochenkov

petrochenkov commented Oct 23, 2016

Copy link
Copy Markdown
Contributor

FWIW, local use $crate; is very similar to use::super; importing the crate root from #37156.
I'd say both should be legal and import a special unusable name, and use $crate as x;/use::super as x; should be legal and declare name x referring to the root module.

@kvarkkvark mentioned this pull request Oct 24, 2016
Closed
@nrc

nrc commented Oct 25, 2016

Copy link
Copy Markdown
Member

@bors r+

Could you file a tracking issue for use $crate; please?

@bors

bors commented Oct 25, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 9106d21 has been approved by nrc

@jseyfriedjseyfried mentioned this pull request Oct 25, 2016
Closed
@jseyfried

jseyfried commented Oct 25, 2016

Copy link
Copy Markdown
ContributorAuthor

cc #37390

@bors

bors commented Oct 25, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37292) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried
jseyfriedforce-pushed the fix_crate_var_regressions branch from 9106d21 to 0d30325CompareOctober 25, 2016 20:41
@jseyfried

jseyfried commented Oct 25, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors r=nrc

@bors

bors commented Oct 25, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 0d30325 has been approved by nrc

@jseyfried

jseyfried commented Oct 25, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors p=1 (this is causing a lot of regressions in practice)

@bors

bors commented Oct 26, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 0d30325 with merge a7557e7...

bors added a commit that referenced this pull request Oct 26, 2016
@bors
Auto merge of#37361- jseyfried:fix_crate_var_regressions, r=nrc
a7557e7
Fix `$crate`-related regressions
Fixes#37345, fixes#37357, fixes#37352, and improves the `unused_extern_crates` lint.
r? @nrc
@bors

bors commented Oct 26, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing a7557e7 to master...

@bors
bors merged commit 0d30325 into rust-lang:masterOct 26, 2016
@jseyfried
jseyfried deleted the fix_crate_var_regressions branch October 26, 2016 05:10
@retep998retep998 mentioned this pull request Oct 27, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrcnrc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE when compiling lewton use $crate; : unresolved import $cratetry!() macro is generating the unused_qualifications lint

4 participants

@jseyfried@petrochenkov@nrc@bors