Uh oh!
There was an error while loading. Please reload this page.
Add identifier to unused import warnings - #37394
Merged
Merged
Conversation
rust-highfive
commented
Oct 25, 2016
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
cramertj
commented
Oct 25, 2016
MemberAuthor
r? @pnkfelix |
oli-obk
reviewed
Oct 25, 2016
Contributor
There was a problem hiding this comment.
you forgot to add the colons after unused import
MemberAuthor
There was a problem hiding this comment.
Of all the silly things... Good catch!
GuillaumeGomez
commented
Oct 25, 2016
Member
Once the semi-colons have been added, it'll be good for me. |
cramertjforce-pushed
the
cramertj/unused-import-with-id
branch
from
October 25, 2016 15:17
54a73d7 to
2bd9418Comparecramertj
commented
Oct 25, 2016
MemberAuthor
@GuillaumeGomez Colons added 😄 |
GuillaumeGomez
commented
Oct 26, 2016
Member
Thanks! @bors: r+ rollup |
bors
commented
Oct 26, 2016
Collaborator
📌 Commit 2bd9418 has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Oct 26, 2016
…h-id, r=GuillaumeGomez Add identifier to unused import warnings Fixrust-lang#37376. For some reason, though, I'm getting warnings with messages like "76:9: 76:16: unused import: `self::g`" instead of "unused import: `self::g`". @pnkfelix Any ideas what might be causing this?
bors added a commit
that referenced
this pull request
Oct 26, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#37376.
For some reason, though, I'm getting warnings with messages like "76:9: 76:16: unused import:
self::g" instead of "unused import:self::g". @pnkfelix Any ideas what might be causing this?