Skip to content

Move CrateConfig from Crate to ParseSess - #37431

Merged
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:refactor_crate_config
Oct 30, 2016
Merged

Move CrateConfig from Crate to ParseSess#37431
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:refactor_crate_config

Conversation

@jseyfried

@jseyfriedjseyfried commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

This is a syntax-[breaking-change]. Most breakage can be fixed by removing a CrateConfig argument.
r? @eddyb

@jseyfried

jseyfried commented Oct 27, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

cc @nnethercote@Manishearth

@nnethercotennethercote mentioned this pull request Oct 27, 2016
Merged
@jseyfried
jseyfriedforce-pushed the refactor_crate_config branch from 85bda0e to 0d4071eCompareOctober 27, 2016 08:33
@eddyb

eddyb commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 27, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 0d4071e has been approved by eddyb

@jseyfried
jseyfriedforce-pushed the refactor_crate_config branch 2 times, most recently from 9482ff7 to faee2cdCompareOctober 27, 2016 11:01
@arielb1

arielb1 commented Oct 27, 2016

Copy link
Copy Markdown
Contributor
failures:
[run-pass] run-pass/ast_stmt_expr_attr.rs
[run-pass] run-pass/compiler-calls.rs
[run-pass] run-pass/macro-crate-does-hygiene-work.rs
[run-pass] run-pass/macro-crate-multi-decorator-literals.rs
[run-pass] run-pass/macro-crate-multi-decorator.rs
[run-pass] run-pass/macro-crate.rs
[run-pass] run-pass/plugin-lib-ok-in-plugin.rs
[run-pass] run-pass/plugin-plus-extern-crate.rs
[run-pass] run-pass/qquote.rs
test result: FAILED. 63 passed; 9 failed; 0 ignored; 0 measured

@bors r-

@jseyfried
jseyfriedforce-pushed the refactor_crate_config branch 5 times, most recently from 895afce to 2619ffdCompareOctober 28, 2016 05:27
@jseyfried

jseyfried commented Oct 28, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors r=eddyb

@bors

bors commented Oct 28, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 2619ffd has been approved by eddyb

@bors

bors commented Oct 29, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37373) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried
jseyfriedforce-pushed the refactor_crate_config branch from 2619ffd to cbd2475CompareOctober 29, 2016 07:53
@jseyfried

jseyfried commented Oct 29, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors r=eddyb

@bors

bors commented Oct 29, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit cbd2475 has been approved by eddyb

@bors

bors commented Oct 30, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cbd2475 with merge 6062e7e...

bors added a commit that referenced this pull request Oct 30, 2016
@bors
Auto merge of#37431- jseyfried:refactor_crate_config, r=eddyb
6062e7e
Move `CrateConfig` from `Crate` to `ParseSess`
This is a syntax-[breaking-change]. Most breakage can be fixed by removing a `CrateConfig` argument.
r? @eddyb
@bors

bors commented Oct 30, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 6062e7e to master...

@bors
bors merged commit cbd2475 into rust-lang:masterOct 30, 2016
This was referenced Oct 30, 2016
Merged
Closed
@jseyfried
jseyfried deleted the refactor_crate_config branch October 30, 2016 21:50
@fuinefuine mentioned this pull request Nov 2, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jseyfried@eddyb@bors@arielb1