Skip to content

Group unused import warnings per import list - #37456

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:unused-imports-verbosity
Nov 11, 2016
Merged

Group unused import warnings per import list#37456
bors merged 1 commit into
rust-lang:masterfrom
estebank:unused-imports-verbosity

Conversation

@estebank

@estebankestebank commented Oct 28, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Given a file

use std::collections::{BinaryHeap,BTreeMap,BTreeSet};fnmain(){}

Show a single warning, instead of three for each unused import:

warning: unused imports, #[warn(unused_imports)] on by default
--> file2.rs:1:24
|
1 | use std::collections::{BinaryHeap, BTreeMap, BTreeSet};
| ^^^^^^^^^^ ^^^^^^^^ ^^^^^^^^

Include support for lints pointing at MultilineSpans, instead of just
Spans.

Fixes#16132.

@rust-highfive

rust-highfive commented Oct 28, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb

eddyb commented Oct 28, 2016

Copy link
Copy Markdown
Contributor

r? @jonathandturner

@rust-highfiverust-highfive assigned sophiajt and unassigned eddybOct 28, 2016
@estebank
estebankforce-pushed the unused-imports-verbosity branch 5 times, most recently from 1fcc56c to 35540acCompareOctober 29, 2016 07:11
@frewsxcv

frewsxcv commented Oct 29, 2016

Copy link
Copy Markdown
Contributor

Might want to check https://s3.amazonaws.com/archive.travis-ci.org/jobs/171581156/log.txt for the test failures

@estebank
estebankforce-pushed the unused-imports-verbosity branch 2 times, most recently from ffbeb3c to c336f15CompareOctober 30, 2016 01:41
eddyb
eddyb reviewed Oct 30, 2016
View reviewed changes
Comment threadsrc/librustc_resolve/check_unused.rs Outdated

@eddybeddybOct 30, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use NodeMap<NodeMap<Span>> here (from rustc::util::nodemap).

@estebank
estebankforce-pushed the unused-imports-verbosity branch 4 times, most recently from c96b6a2 to 8c745d6CompareOctober 31, 2016 02:36
@sophiajt

sophiajt commented Oct 31, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 31, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 8c745d6 has been approved by jonathandturner

@bors

bors commented Oct 31, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37191) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
estebankforce-pushed the unused-imports-verbosity branch from 8c745d6 to 2a82785CompareOctober 31, 2016 23:37
@estebank

estebank commented Oct 31, 2016

Copy link
Copy Markdown
ContributorAuthor

@jonathandturner rebased to fix merge conflict and while I was at it, squashed to clean commit history.

@bors

bors commented Nov 1, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37497) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
estebankforce-pushed the unused-imports-verbosity branch from 2a82785 to 0c47923CompareNovember 1, 2016 18:15
@bors

bors commented Nov 4, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #37167) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Group unused import warnings per path list
a820d99
Given a file
```rust
use std::collections::{BinaryHeap, BTreeMap, BTreeSet};
fn main() {}
```
Show a single warning, instead of three for each unused import:
```nocode
warning: unused imports, #[warn(unused_imports)] on by default
--> foo.rs:1:24
|
1 | use std::collections::{BinaryHeap, BTreeMap, BTreeSet};
| ^^^^^^^^^^ ^^^^^^^^ ^^^^^^^^
```
Include support for lints pointing at `MultilineSpan`s, instead of just
`Span`s.
@estebank
estebankforce-pushed the unused-imports-verbosity branch from 0c47923 to a820d99CompareNovember 9, 2016 15:41
@alexcrichton

alexcrichton commented Nov 10, 2016

Copy link
Copy Markdown
Member

@bors: r=jonathandturner

(assuming nothing changed, but @jonathandturner feel free to correct me!)

btw I'm pretty stoked about this change!

@bors

bors commented Nov 10, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit a820d99 has been approved by jonathandturner

@brsonbrson added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 11, 2016
@brson

brson commented Nov 11, 2016

Copy link
Copy Markdown
Contributor

Sweet fix for an ancient bug!

@bors

bors commented Nov 11, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a820d99 with merge 5293b91...

bors added a commit that referenced this pull request Nov 11, 2016
@bors
Auto merge of#37456- estebank:unused-imports-verbosity, r=jonathand…
5293b91
…turner
Group unused import warnings per import list
Given a file
``` rust
use std::collections::{BinaryHeap, BTreeMap, BTreeSet};
fn main() {}
```
Show a single warning, instead of three for each unused import:
``` nocode
warning: unused imports, #[warn(unused_imports)] on by default
--> file2.rs:1:24
|
1 | use std::collections::{BinaryHeap, BTreeMap, BTreeSet};
| ^^^^^^^^^^ ^^^^^^^^ ^^^^^^^^
```
Include support for lints pointing at `MultilineSpan`s, instead of just
`Span`s.
Fixes#16132.
@bors

bors commented Nov 11, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: jonathandturner
Pushing 5293b91 to master...

@bors
bors merged commit a820d99 into rust-lang:masterNov 11, 2016
@emberian

emberian commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

\o/ you're awesome, @estebank

@estebank
estebank deleted the unused-imports-verbosity branch November 9, 2023 05:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@eddybeddybeddyb left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@sophiajtsophiajt

Labels

relnotesMarks issues that should be documented in the release notes of the next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@estebank@rust-highfive@eddyb@frewsxcv@sophiajt@bors@alexcrichton@brson@emberian