Uh oh!
There was an error while loading. Please reload this page.
Fix grammar verification - #37607
Conversation
alexcrichton
left a comment
There was a problem hiding this comment.
Nice! Hopefully we'll be able to easily get a "bot" up and running for this soon once we switch to Travis
There was a problem hiding this comment.
Would it be possible to abstract this to avoid hardcoding it?
There was a problem hiding this comment.
Do you mean something like this?
echo $(find /usr/ -name antlr-complete.jar 2>/dev/null)
There was a problem hiding this comment.
I was thinking more of a ./configure style thing (or detection elsewhere)
steveklabnik
commented
Nov 7, 2016
Cool! |
alexcrichton
commented
Nov 10, 2016
@dns2utf8 thoughts about configuring where antlr itself is located given my previous comment? |
There was a problem hiding this comment.
Not sure to see the usefulness of this change...
There was a problem hiding this comment.
Well I read it and I thought I change it. Is it wrong?
There was a problem hiding this comment.
Well it's not wrong, but "it's is just as good as "it is" so why changing it?
There was a problem hiding this comment.
I learned it that way in school, an old habit.
dns2utf8
commented
Nov 13, 2016
@alexcrichton I have never worked with the configure-step. I am looking into it now. |
There was a problem hiding this comment.
I have a strange bug: With this line i save the CFG_ANTLR4_JAR to the generated config but it also generates an additional line after this entry.
That entry is empty and stops the use of the config.mk.
Do you have an idea?
There was a problem hiding this comment.
Is that perhaps because the quote after JAR isn't terminated?
There was a problem hiding this comment.
I was unable to fix the bug inline without creating another one. So I rewrote it with a unfortunately global variable.
dns2utf8
commented
Nov 16, 2016
I extended the find to search the users homedirectory for |
* Use `make check-lexer` to verify the grammar. * Extend grammar/README * Add make clean-grammar rule * Add target `check-build-lexer-verifier` to `make tidy`, so it will build the verifier with every build and catch future errors * Search for antlr4 with configure and find
alexcrichton
commented
Nov 17, 2016
@bors: r+ |
bors
commented
Nov 17, 2016
📌 Commit 0e1828a has been approved by |
bors
commented
Nov 17, 2016
Fix grammar verification * Use make check-lexer to verify the grammar. * Extend grammar/README * Add make clean-grammar rule * Add target check-build-lexer-verifier to make tidy, so it will build the verifier with every build and catch future errors This is the continuation of #34994 r? @steveklabnik@jonathandturner@alexcrichton
This is the continuation of #34994
r? @steveklabnik@jonathandturner@alexcrichton