Skip to content

Document the question mark operator in reference and the book's syntax index - #37664

Merged
bors merged 1 commit into
rust-lang:masterfrom
est31:master
Nov 10, 2016
Merged

Document the question mark operator in reference and the book's syntax index#37664
bors merged 1 commit into
rust-lang:masterfrom
est31:master

Conversation

@est31

@est31est31 commented Nov 9, 2016

Copy link
Copy Markdown
Member

The question mark operator will be stabilized for the Rust 1.13 release (unfortunately). Even though I don't like the operator, it still should be documented in the syntax index in the book and in the reference.

Maybe there are people who also want to change the book's chapters on error handling, depending on their views of what idiomatic error handling is, now that the operator is stable, but I don't want to and I'd prefer to keep this PR focused on the reference and syntax index only.

Please also apply this PR to the beta branch of rust.

@rust-highfive

rust-highfive commented Nov 9, 2016

Copy link
Copy Markdown
Contributor

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@est31est31 changed the title Document the question mark operatorDocument the question mark operator in reference and the book's syntax indexNov 9, 2016
Manishearth
Manishearth reviewed Nov 9, 2016
View reviewed changes
Comment threadsrc/doc/reference.md Outdated

@ManishearthManishearthNov 9, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space after comma in result

Manishearth
Manishearth reviewed Nov 9, 2016
View reviewed changes
Comment threadsrc/doc/book/syntax-index.md Outdated

@ManishearthManishearthNov 9, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error propagation

@Manishearth

Manishearth commented Nov 9, 2016

Copy link
Copy Markdown
Member

r=me with nits

@Manishearth

Manishearth commented Nov 9, 2016

Copy link
Copy Markdown
Member

@bors r+ rollup

thanks!

@bors

bors commented Nov 9, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit cf20943 has been approved by Manishearth

@est31

est31 commented Nov 9, 2016

Copy link
Copy Markdown
MemberAuthor

Sorry, I've forgotten two backticks. @Manishearth can you re-review?

@KalitaAlexey

KalitaAlexey commented Nov 9, 2016

Copy link
Copy Markdown
Contributor

Dear @Manishearth,
Have ? behavior been changed to work only for Result or it still works with any T: Carrier?
If it is the latter case, then I think it must be documented anywhere.

@Manishearth

Manishearth commented Nov 9, 2016

Copy link
Copy Markdown
Member

Yes, I think it works with carrier, but it's unstable.

deferring to nrc who pushed for the carrier stuff iirc

r? @nrc

@rust-highfiverust-highfive assigned nrc and unassigned ManishearthNov 9, 2016
@KalitaAlexey

KalitaAlexey commented Nov 9, 2016

Copy link
Copy Markdown
Contributor

Is ? going to be stabilized without Carrier?

@Manishearth

Manishearth commented Nov 9, 2016

Copy link
Copy Markdown
Member

I think it already was? Carrier can be stabilized later.

@nrc

nrc commented Nov 9, 2016

Copy link
Copy Markdown
Member

Yes, I think it works with carrier, but it's unstable.

This correct

@nrcnrc added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 9, 2016
@nrc

nrc commented Nov 9, 2016

Copy link
Copy Markdown
Member

@bors: r+ rollup

(The Carrier trait exists, but only for purposes of future compatibility, I don't think it should be advertised/documented)

@bors

bors commented Nov 9, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 1e9aad7 has been approved by nrc

eddyb added a commit to eddyb/rust that referenced this pull request Nov 10, 2016
@eddyb
Rollup merge ofrust-lang#37664- est31:master, r=nrc
e733667
Document the question mark operator in reference and the book's syntax index
The question mark operator will be stabilized for the Rust 1.13 release (unfortunately). Even though I don't like the operator, it still should be documented in the syntax index in the book and in the reference.
Maybe there are people who also want to change the book's chapters on error handling, depending on their views of what idiomatic error handling is, now that the operator is stable, but I don't want to and I'd prefer to keep this PR focused on the reference and syntax index only.
Please also apply this PR to the beta branch of rust.
@eddybeddyb mentioned this pull request Nov 10, 2016
Merged
bors added a commit that referenced this pull request Nov 10, 2016
@bors
Auto merge of#37678- eddyb:rollup, r=eddyb
b46ce08
Rollup of 5 pull requests
- Successful merges: #37402, #37412, #37661, #37664, #37667
- Failed merges:
@bors
bors merged commit 1e9aad7 into rust-lang:masterNov 10, 2016
@brsonbrson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 10, 2016
@brson

brson commented Dec 10, 2016

Copy link
Copy Markdown
Contributor

Reasonable backport.

@brsonbrson mentioned this pull request Dec 15, 2016
Merged
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 15, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ManishearthManishearthManishearth left review comments

Assignees

@nrcnrc

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@est31@rust-highfive@Manishearth@bors@KalitaAlexey@nrc@brson@alexcrichton