Uh oh!
There was an error while loading. Please reload this page.
[RFC] Add flag for Unicode based Frontend support - #37703
Conversation
rust-highfive
commented
Nov 11, 2016
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
frewsxcv
commented
Nov 11, 2016
eddyb
commented
Nov 11, 2016
sophiajt
commented
Nov 12, 2016
Unfortunately, while this helps with some platforms, other platforms like Windows can't experience it. In the RFC for the new error format, we call out that Unicode should not be supported: https://github.com/rust-lang/rfcs/blob/master/text/1644-default-and-expanded-rustc-errors.md#format-of-error-messages That said, there are probably ways we can improve some of our ascii drawing for better readability in some cases, like the multiline case. |
bors
commented
Nov 23, 2016
☔ The latest upstream changes (presumably #37681) made this pull request unmergeable. Please resolve the merge conflicts. |
steveklabnik
commented
Jan 3, 2017
@jonathandturner I'm going to take that comment as an "this should be closed", then. Let me know if that's wrong! Thanks @estebank but we can't accept this patch. |
Using PR #21406 as a base, I took a stab at #24387.
It currently looks like this:

As you can see, there's still some work left to do in order for the different combinations of underlines to look right, but the basic logic is already all there.