Uh oh!
There was an error while loading. Please reload this page.
book: replace example I do not understand - #37956
Conversation
rust-highfive
commented
Nov 23, 2016
(rust_highfive has picked a reviewer for you, use r? to override) |
leoyvens
commented
Nov 23, 2016
That refers to running a server, servers run in an infinite loop so an example that runs a server would hang your tests. |
GuillaumeGomez
commented
Nov 23, 2016
I don't find this change useful. :-/ |
There was a problem hiding this comment.
Having the comma inside the quotations is correct here, as the docs are written in American English. (I remember seeing this specified somewhere...)
steveklabnik
commented
Nov 23, 2016
r=me after the comma fix |
tshepang
commented
Nov 24, 2016
@bors: r? @steveklabnik |
steveklabnik
commented
Dec 12, 2016
Re-starting travis; hopefully it's fixed by now. |
There was a problem hiding this comment.
the original grammar is odd but correct, since "examples" is plural and so the sentence is "examples [..], which you would want to ensure compile." Adding "it" is incorrect because "which" is already the subject of "compile". Alternatively you could write e.g. "an example such as [..]: you would want to ensure it compiles, but it might be..." which is probably less confusing overall.
steveklabnik
commented
Dec 22, 2016
tshepang
commented
Dec 23, 2016
will do |
tshepang
commented
Dec 23, 2016
updated @steveklabnik, thanks @goffrie |
steveklabnik
commented
Dec 24, 2016
@bors: r+ rollup |
bors
commented
Dec 24, 2016
📌 Commit d8ee074 has been approved by |
book: replace example I do not understand
No description provided.