Skip to content

Document how lock 'guard' structures are created. - #38010

Merged
bors merged 3 commits into
rust-lang:masterfrom
frewsxcv:lock-creations
Nov 26, 2016
Merged

Document how lock 'guard' structures are created.#38010
bors merged 3 commits into
rust-lang:masterfrom
frewsxcv:lock-creations

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Nov 25, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@frewsxcv

frewsxcv commented Nov 25, 2016

Copy link
Copy Markdown
ContributorAuthor

r? @GuillaumeGomez

@rust-highfive

rust-highfive commented Nov 25, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez
GuillaumeGomez reviewed Nov 25, 2016
View reviewed changes
Comment threadsrc/libstd/sync/mutex.rs Outdated

@GuillaumeGomezGuillaumeGomezNov 25, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not PR-bound but shouldn't be a dot present a the end of this sentence?

GuillaumeGomez
GuillaumeGomez requested changes Nov 25, 2016
View reviewed changes

@GuillaumeGomezGuillaumeGomez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit and it's good.

Comment threadsrc/libstd/sync/rwlock.rs Outdated

@GuillaumeGomezGuillaumeGomezNov 25, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace in "[read()] and".

@frewsxcv

frewsxcv commented Nov 25, 2016

Copy link
Copy Markdown
ContributorAuthor

Comments have been addressed.

@GuillaumeGomez

GuillaumeGomez commented Nov 26, 2016

Copy link
Copy Markdown
Member

Now squash time! \o/ (just the last commit)

@frewsxcv
Document how the MutexGuard structure is created.
6075af4
Also, end sentence with a period.
@GuillaumeGomez

GuillaumeGomez commented Nov 26, 2016

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Nov 26, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 6075af4 has been approved by GuillaumeGomez

sanxiyn added a commit to sanxiyn/rust that referenced this pull request Nov 26, 2016
@sanxiyn
Rollup merge ofrust-lang#38010- frewsxcv:lock-creations, r=Guillaum…
44b926a
…eGomez
Document how lock 'guard' structures are created.
@sanxiynsanxiyn mentioned this pull request Nov 26, 2016
Merged
bors added a commit that referenced this pull request Nov 26, 2016
@bors
Auto merge of#38015- sanxiyn:rollup, r=sanxiyn
7e39c0e
Rollup of 7 pull requests
- Successful merges: #37962, #37963, #37967, #37978, #37985, #38001, #38010
- Failed merges:
@bors
bors merged commit 6075af4 into rust-lang:masterNov 26, 2016
@frewsxcv
frewsxcv deleted the lock-creations branch December 4, 2016 20:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@frewsxcv@rust-highfive@GuillaumeGomez@bors@sfackler