Uh oh!
There was an error while loading. Please reload this page.
rustbuild: Use src/rustc for assembled compilers - #38076
Merged
Merged
Conversation
The `src/rustc` path is intended for assembling a compiler (e.g. the bare bones) not actually compiling the whole compiler itself. This path was accidentally getting hijacked to represent the whole compiler being compiled, so let's redirect that elsewhere for that particular cargo project. Closesrust-lang#38039
rust-highfive
commented
Nov 29, 2016
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
With this and #38050, following the repro steps in #38039 (comment) results in rustbuild doing no work: (I haven't tried this PR in isolation) |
japaric
commented
Nov 30, 2016
Contributor
(I haven't tried this PR in isolation) Tested. Same problem. |
alexcrichton
commented
Dec 1, 2016
MemberAuthor
alexcrichton
commented
Dec 1, 2016
MemberAuthor
er #37817 |
Contributor
OK. Tested again this + #37817. Using the repro instructions in #38039 (comment), now I get: Which is better but the stage numbering seems strange: Is this using the "snapshot" (the stage0 compiler) to build the ARM compiler? Or is it using the compiler produced by this step: ? If the former then that ^ step (or rather, the first 4 steps) wouldn't be necessary right? EDIT: Fixed the x.py command |
alexcrichton
commented
Dec 1, 2016
MemberAuthor
Had some discussion with @japaric on IRC, and the conclusion was that if the command switches |
japaric
commented
Dec 3, 2016
Contributor
r=me after #37817 lands |
japaric
commented
Dec 7, 2016
Contributor
@bors r+ |
bors
commented
Dec 7, 2016
Collaborator
📌 Commit 8e9f7f5 has been approved by |
bors
commented
Dec 8, 2016
Collaborator
bors added a commit
that referenced
this pull request
Dec 8, 2016
rustbuild: Use src/rustc for assembled compilers The `src/rustc` path is intended for assembling a compiler (e.g. the bare bones) not actually compiling the whole compiler itself. This path was accidentally getting hijacked to represent the whole compiler being compiled, so let's redirect that elsewhere for that particular cargo project. Closes#38039
bors
commented
Dec 8, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
src/rustcpath is intended for assembling a compiler (e.g. the bare bones)not actually compiling the whole compiler itself. This path was accidentally
getting hijacked to represent the whole compiler being compiled, so let's
redirect that elsewhere for that particular cargo project.
Closes#38039