Uh oh!
There was an error while loading. Please reload this page.
Require #[proc_macro_derive] functions to be pub - #38140
Merged
Merged
Conversation
nrc
commented
Dec 3, 2016
Member
cc @alexcrichton and #35900 |
nrc
commented
Dec 3, 2016
Member
r = me, but I just want a chance for people to see this before I land it. |
53 tasks
jseyfriedforce-pushed
the
proc_macro_visibility
branch
from
December 3, 2016 04:03
8290c84 to
9c968c5Comparealexcrichton
commented
Dec 3, 2016
Member
Oh I thought this was already the case, I even vaguely remember adding a test for this... In any case looks good to me as well! |
bors
commented
Dec 8, 2016
Collaborator
☔ The latest upstream changes (presumably #38191) made this pull request unmergeable. Please resolve the merge conflicts. |
jseyfriedforce-pushed
the
proc_macro_visibility
branch
from
December 8, 2016 04:48
9c968c5 to
6e93d5dComparejseyfriedforce-pushed
the
proc_macro_visibility
branch
from
December 15, 2016 03:03
6e93d5d to
1605254Comparenrc
commented
Dec 18, 2016
Member
@bors: r+ |
bors
commented
Dec 18, 2016
Collaborator
📌 Commit 1605254 has been approved by |
bors
commented
Dec 19, 2016
Collaborator
⌛ Testing commit 1605254 with merge 0102127... |
bors added a commit
that referenced
this pull request
Dec 19, 2016
Require `#[proc_macro_derive]` functions to be `pub` r? @nrc
bors
commented
Dec 19, 2016
Collaborator
alexcrichton
commented
Dec 19, 2016
Member
This just made it into beta, so de-nominating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @nrc