Uh oh!
There was an error while loading. Please reload this page.
libtest: add --exact to make filter matching exact - #38181
Conversation
rust-highfive
commented
Dec 5, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Filter matching is by substring by default. This makes it impossible to run a single test if its name is a substring of some other test. For example, its not possible to run just "mymod::test" with these tests: mymod::test mymod::test1 mymod::test_module::moretests You could declare by convention that no test has a name that's a substring of another test, but that's not really practical. This PR adds the "--exact" flag, to make filter matching exactly match the complete name.
sfackler
commented
Dec 6, 2016
Seems reasonable to me, though I'll defer to the @rust-lang/rools team. This is something that's bugged me in the past! |
alexcrichton
commented
Dec 13, 2016
@bors: r+ |
bors
commented
Dec 13, 2016
📌 Commit 5bf4d6f has been approved by |
bors
commented
Dec 14, 2016
libtest: add --exact to make filter matching exact Filter matching is by substring by default. This makes it impossible to run a single test if its name is a substring of some other test. For example, its not possible to run just `mymod::test` with these tests: ``` mymod::test mymod::test1 mymod::test_module::moretests ``` You could declare by convention that no test has a name that's a substring of another test, but that's not really practical. This PR adds the `--exact` flag, to make filter matching exactly match the complete name.
Filter matching is by substring by default. This makes it impossible
to run a single test if its name is a substring of some other test.
For example, its not possible to run just
mymod::testwith thesetests:
You could declare by convention that no test has a name that's a
substring of another test, but that's not really practical.
This PR adds the
--exactflag, to make filter matching exactlymatch the complete name.