Skip to content

Handle Ctrl+C in the build script - #38299

Merged
bors merged 1 commit into
rust-lang:masterfrom
achanda:ctrl-c
Dec 13, 2016
Merged

Handle Ctrl+C in the build script#38299
bors merged 1 commit into
rust-lang:masterfrom
achanda:ctrl-c

Conversation

@achanda

@achandaachanda commented Dec 11, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Dec 11, 2016

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

alexcrichton commented Dec 11, 2016

Copy link
Copy Markdown
Member

Thanks for the PR! We want to be sure to kill the subprocess as well, though, so can you confirm that the call to the build system is killed?

@achanda

achanda commented Dec 11, 2016

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton I just checked, all sub processes are killed on a Ctrl+C. Feel free to cross check though!

@brson

brson commented Dec 11, 2016

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Dec 11, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit b7cd840 has been approved by brson

@achanda

achanda commented Dec 12, 2016

Copy link
Copy Markdown
ContributorAuthor

Not sure why the test failed. I don't see any indications in https://travis-ci.org/rust-lang/rust/jobs/183028434 . Should we just retry?

@petrochenkov

petrochenkov commented Dec 12, 2016

Copy link
Copy Markdown
Contributor

@achanda
Travis tests status isn't taken into account when merging, it's only informative (all Travis testing is also broken at the moment).
You can see the actual status of this PR in https://buildbot.rust-lang.org/homu/queue/rust - it it's still in the queue and hasn't failed, so there's no need to retry.

@achanda

achanda commented Dec 12, 2016

Copy link
Copy Markdown
ContributorAuthor

I see, thanks!

@frewsxcvfrewsxcv mentioned this pull request Dec 12, 2016
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 12, 2016
@frewsxcv
Rollup merge ofrust-lang#38299- achanda:ctrl-c, r=brson
1a2e37c
Handle Ctrl+C in the build script
@frewsxcvfrewsxcv mentioned this pull request Dec 12, 2016
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 12, 2016
@frewsxcv
Rollup merge ofrust-lang#38299- achanda:ctrl-c, r=brson
cba1304
Handle Ctrl+C in the build script
bors added a commit that referenced this pull request Dec 13, 2016
@bors
Auto merge of#38325- frewsxcv:rollup, r=frewsxcv
5a2b50b
Rollup of 7 pull requests
- Successful merges: #37052, #37941, #38067, #38164, #38202, #38264, #38299
- Failed merges:
@bors
bors merged commit b7cd840 into rust-lang:masterDec 13, 2016
@achanda
achanda deleted the ctrl-c branch December 13, 2016 08:40
@petrochenkov

petrochenkov commented Mar 3, 2017

Copy link
Copy Markdown
Contributor

@achanda
What was the goal of this patch?
KeyboardInterrupt is caught only to exit successfully (with exit code 0), this doesn't seem right.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@achanda@rust-highfive@alexcrichton@brson@bors@petrochenkov@nikomatsakis