Uh oh!
There was an error while loading. Please reload this page.
Clarify zero-value behavior of ctlz/cttz intrinsics. - #38310
Conversation
rust-highfive
commented
Dec 12, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
frewsxcv
commented
Dec 12, 2016
Hold off on reviewing. Going to discuss this at this week's docs team meeting. |
aturon
commented
Dec 12, 2016
@frewsxcv Ok, let me know when you're ready. |
There was a problem hiding this comment.
First of all, underlying LLVM intrinsic has a prototype that looks like this:
declare iXYZ @llvm.ctlz.iXYZ(iXYZ <src>, i1 <is_zero_undef>)
so comparing it to the underlying LLVM intrinsic is not quite right :)
There was a problem hiding this comment.
I could just ditch this sentence and not talk about LLVM but leave the x = 0 example.
There was a problem hiding this comment.
Removed that sentence in the latest force push.
frewsxcv
commented
Dec 14, 2016
pnkfelix
commented
Jan 3, 2017
@bors r+ rollup |
bors
commented
Jan 3, 2017
📌 Commit a99f70b has been approved by |
Clarify zero-value behavior of `ctlz`/`cttz` intrinsics. Fixesrust-lang#34381.
Clarify zero-value behavior of `ctlz`/`cttz` intrinsics. Fixesrust-lang#34381.
bors
commented
Jan 9, 2017
Clarify zero-value behavior of `ctlz`/`cttz` intrinsics. Fixes#34381.
bors
commented
Jan 9, 2017
☀️ Test successful - status-appveyor, status-travis |
Fixes#34381.