Uh oh!
There was an error while loading. Please reload this page.
Fix unaligned loads in librustc_metadata - #38352
Merged
Merged
Conversation
rust-highfive
commented
Dec 13, 2016
Contributor
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
bluss
commented
Dec 13, 2016
ContributorAuthor
ContributorAuthor
There was a problem hiding this comment.
hm.. no, sorry! It is from before that.
bluss
commented
Dec 13, 2016
ContributorAuthor
This was reported as a crash on sparc64. |
blussforce-pushed
the
unaligned-metadata
branch
from
December 13, 2016 16:55
60fd4e4 to
e6dc830Comparebluss
commented
Dec 13, 2016
ContributorAuthor
There was a problem hiding this comment.
Maybe we should lint against this? Creating a slice or reference from a less aligned pointer?
Creating a `&[u32]` from a `&[u8]` was not valid; the data is not necessarily well aligned.
blussforce-pushed
the
unaligned-metadata
branch
from
December 14, 2016 00:02
e6dc830 to
7bc1054Comparebluss
commented
Dec 14, 2016
ContributorAuthor
Hey presto, the diff is much shorter with a bit of help from @eddyb. |
eddyb
commented
Dec 14, 2016
Contributor
@bors r+ |
bors
commented
Dec 14, 2016
Collaborator
📌 Commit 7bc1054 has been approved by |
bors
commented
Dec 16, 2016
Collaborator
bors added a commit
that referenced
this pull request
Dec 16, 2016
Fix unaligned loads in librustc_metadata Creating a `&[u32]` from an `&[u8]` is not necessarily valid, and crashes on certain platforms if the data is not well aligned.
bors
commented
Dec 16, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a
&[u32]from an&[u8]is not necessarily valid, and crasheson certain platforms if the data is not well aligned.