Uh oh!
There was an error while loading. Please reload this page.
Move futures to std, etc - #3842
Merged
Merged
Conversation
brson
commented
Oct 25, 2012
ContributorAuthor
nikomatsakis
commented
Oct 25, 2012
Contributor
r+ |
bors pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
3842: Add lib-proc-macro mod in ra_proc_macro_srv r=matklad a=edwin0cheng This PR add a module in ra_proc_macro_srv, which is just copy & paste from rustc lib_proc_macro and remove all unstable features in it. The main idea here is by doing that, we could build the `ra_proc_macro_srv` without nightly compiler and remain ABI compatibility. Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2491
Futures are not that important to Rust - oneshot pipes can be used in most cases. I will feel more comfortable not making them a core dependency. The only significant effect this has is that task::future_result now just uses a pipes::Chan instead of a future.