Uh oh!
There was an error while loading. Please reload this page.
Implement typechecking for tuple structs - #3848
Conversation
nikomatsakis
commented
Oct 24, 2012
So, reading the code a bit more, my feeling is that there is no good reason to have the variant code and struct code do the same thing in two different places. I'd be happier saying r+ if the AST were refactored as necessary so that both structs and variants point to the same kind of AST node (perhaps |
pcwalton
commented
Oct 24, 2012
I do have plans to do that, yes, but part of the problem is that trans does have to treat them differently, due to the way enums are opaque and structs aren't, and enums have a discriminant and structs don't. So I don't think we'll get quite as much reuse as you were hoping (for example, ctor functions and patterns will need to be translated totally differently). There could definitely be more reuse at the AST level though. |
nikomatsakis
commented
Oct 24, 2012
OK---I think we can get quite a bit of reuse in trans, but yes of course |
Add tokio io test After rust-lang#3804 landed, these tests passed.
3848: Remove unused dependencies r=kjeremy a=est31 Found by cargo-udeps Co-authored-by: est31 <MTest31@outlook.com>
r? @nikomatsakis