Skip to content

resolve: fix non-termination - #38539

Merged
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:fix_resolve_hang
Dec 25, 2016
Merged

resolve: fix non-termination#38539
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:fix_resolve_hang

Conversation

@jseyfried

@jseyfriedjseyfried commented Dec 22, 2016

Copy link
Copy Markdown
Contributor

Fixes#34324.
r? @eddyb

jseyfried
jseyfried commented Dec 22, 2016
View reviewed changes
Comment threadsrc/test/compile-fail/recursive-reexports.rs Outdated

@jseyfriedjseyfriedDec 22, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test used to be broken 😳

@eddyb

eddyb commented Dec 22, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Dec 22, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit ff54a4e has been approved by eddyb

@eddyb

eddyb commented Dec 22, 2016

Copy link
Copy Markdown
Contributor

Does this need a backport?

@jseyfried

jseyfried commented Dec 22, 2016

Copy link
Copy Markdown
ContributorAuthor

Yeah, I think this would be a good idea to backport.

@jseyfriedjseyfried added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 22, 2016
@jseyfriedjseyfried mentioned this pull request Dec 22, 2016
Closed
@eddybeddyb added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 22, 2016
@jseyfried

jseyfried commented Dec 23, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors r=eddyb

@bors

bors commented Dec 23, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 098c9b6 has been approved by eddyb

@jseyfried

jseyfried commented Dec 25, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors p=1

@bors

bors commented Dec 25, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 098c9b6 with merge 20b6c16...

bors added a commit that referenced this pull request Dec 25, 2016
@bors
Auto merge of#38539- jseyfried:fix_resolve_hang, r=eddyb
20b6c16
resolve: fix non-termination
Fixes#34324.
r? @eddyb
@bors

bors commented Dec 25, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 20b6c16 to master...

1 similar comment
@bors

bors commented Dec 25, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 20b6c16 to master...

@bors
bors merged commit 098c9b6 into rust-lang:masterDec 25, 2016
@jseyfried
jseyfried deleted the fix_resolve_hang branch December 26, 2016 05:51
@jseyfriedjseyfried mentioned this pull request Dec 26, 2016
Closed
@nikomatsakis

nikomatsakis commented Dec 30, 2016

Copy link
Copy Markdown
Contributor

Marking as beta-accepted. Small patch, serious regression. cc @rust-lang/compiler

@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 30, 2016
@alexcrichtonalexcrichton mentioned this pull request Dec 30, 2016
Merged
@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 30, 2016
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jun 7, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jseyfried@eddyb@bors@nikomatsakis@brson