Uh oh!
There was an error while loading. Please reload this page.
Issue 2263 fn subtyping - #3854
Closed
nikomatsakis wants to merge 2 commits into
Closed
Conversation
brson
commented
Oct 25, 2012
Contributor
r+ Great comments and tests. Took me a while to digest how region inference works, but it lgtm. |
nikomatsakis
commented
Oct 25, 2012
ContributorAuthor
Merged in 1a3a707 |
RalfJung pushed a commit
to RalfJung/rust
that referenced
this pull request
Sep 8, 2024
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
4268: Support auto-import in macro r=SomeoneToIgnore a=edwin0cheng Fixed: rust-lang#3854 Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @brson
This is a partial fix for #2263. It corrects subtyping for function types with bound lifetimes, but not LUB/GLB. The description in the comment in region_inference.rs (included in the patch) explains the situation as best I can, it's a fairly subtle problem, I won't repeat it here.