Uh oh!
There was an error while loading. Please reload this page.
Document how the compiler disambiguates variable patterns from variant p... - #3859
Closed
catamorphism wants to merge 1 commit into
Closed
Document how the compiler disambiguates variable patterns from variant p...#3859catamorphism wants to merge 1 commit into
catamorphism wants to merge 1 commit into
Conversation
brson
commented
Oct 25, 2012
Contributor
r+ Seems clear to me. Some discussion about how our conventions avoid this problem could be enlightening, but maybe that isn't appropriate for the reference manual. |
catamorphism
commented
Oct 25, 2012
ContributorAuthor
Merged in 0ef75a6 (I added a sentence about naming variants with upper-case letters). |
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 25, 2021
Rework use_self impl based on ty::Ty comparison rust-lang#3410 | Take 2 This builds on top of rust-lang#5531 I already reviewed and approved the commits by `@montrivo.` So only the review of my commits should be necessary. I would also appreciate your review `@montrivo,` since you are familiar with the challenges here. Fixesrust-lang#3410 and Fixesrust-lang#4143 (same problem) Fixesrust-lang#2843Fixesrust-lang#3859Fixesrust-lang#4734 and fixesrust-lang#6221Fixesrust-lang#4305Fixesrust-lang#5078 (even at expression level now 🎉) Fixesrust-lang#3881 and Fixesrust-lang#4887 (same problem) Fixesrust-lang#3909 Not yet: rust-lang#4140 (test added) All the credit for the fixes goes to `@montrivo.` I only refactored and copy and pasted his code. changelog: rewrite [`use_self`] lint and fix multiple (8) FPs. One to go.
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
3859: Update serde_json r=kjeremy a=kjeremy Grabs fix for serde-rs/json#647 Co-authored-by: kjeremy <kjeremy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...atterns
See #3851
r? @brson -- I wanted to request review on this to make sure what I wrote was clear.