Uh oh!
There was an error while loading. Please reload this page.
Detect mips CPUs in ./configure - #38650
Conversation
rust-highfive
commented
Dec 28, 2016
(rust_highfive has picked a reviewer for you, use r? to override) |
xen0n
left a comment
There was a problem hiding this comment.
Thanks for spotting this! I forgot to touch configure in my MIPS host build PR because the MIPS64 platform I was working on is rustbuild-only. Looks good overall!
There was a problem hiding this comment.
Here od isn't need_cmd'd, thus unsafe to rely on. You could refer to the rustup-init.sh implementation for an alternative that only requires head and tail.
There was a problem hiding this comment.
od is part of POSIX (including the -d and -A n options), just as head and tail are. Is that good enough? If not, I can do your suggestion.
There was a problem hiding this comment.
I don't know, but some exotic environments indeed doesn't have od; a quick Googling reveals OpenWRT and Maemo and the such. I don't know how many people are compiling Rust on these platforms though...
There was a problem hiding this comment.
In order to minimize the possible impact of this change, could this move into just the mips block below?
infinity0
commented
Dec 28, 2016
Welcome! In the meantime I spotted some more things which are missing:
I'll fix these as well and add them to this PR. In the long run, does the rust team have any plans to unify the Makefiles and rustup/rustbuild? Seems like unnecessary work to have to maintain both of these... |
xen0n
commented
Dec 28, 2016
@infinity0 Please refrain from touching the makefiles, they're slated to be deleted pretty soon! |
infinity0
commented
Dec 28, 2016
Ouch, OK. Is there a way to not use Cargo to build rust? That is going to make bootstrapping new architectures much much more difficult. |
@infinity0 No, bootstrapping will be arguably easier, since you no longer have to deal with multiple different build tools with rustbuild. Look at the way |
infinity0
commented
Dec 28, 2016
Er, I am doing bootstrapping literally right now, and I can tell you it will be harder. All of the previous tools like |
sylvestre
commented
Dec 28, 2016
👍 to what @infinity0 just said. |
alexcrichton
commented
Dec 28, 2016
This PR looks good to me, thanks @infinity0! |
This mirrors existing logic already in src/bootstrap/bootstrap.py
infinity0
commented
Jan 12, 2017
OK, I've moved mention |
alexcrichton
commented
Jan 12, 2017
@bors: r+ Thanks! It's ok to not update those unless necessary. |
bors
commented
Jan 12, 2017
📌 Commit 246e749 has been approved by |
bors
commented
Jan 12, 2017
Detect mips CPUs in ./configure This mirrors existing logic already in src/bootstrap/bootstrap.py
bors
commented
Jan 13, 2017
☀️ Test successful - status-appveyor, status-travis |
This mirrors existing logic already in src/bootstrap/bootstrap.py