Uh oh!
There was an error while loading. Please reload this page.
Update sign formatting for numeric types in docs - #38704
Conversation
rust-highfive
commented
Dec 30, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
brson
commented
Jan 3, 2017
bors
commented
Jan 3, 2017
📌 Commit 5e836ae has been approved by |
GuillaumeGomez
commented
Jan 4, 2017
Tidy issue: @bors: r- |
There was a problem hiding this comment.
Url shouldn't be formatted this way. First the [pad_integrad] then below [pad_integral]: struct.Formatter.html#method.pad_integral
There was a problem hiding this comment.
And url should be: ../std/fmt/struct.Formatter.html#method.pad_integral.
Sign formatting is no longer controlled by a `Signed` trait. Instead, `pad_integral` is used and implemented for numeric types by default. Fixes#38677
@GuillaumeGomez I have fixed the formatting for the link. The link as is works on my local build of
|
GuillaumeGomez
commented
Jan 4, 2017
Tests passed, you fixed the issue, all good! Thanks for your work! PS: my url missed a "..", but it doesn't matter if yours works just fine. @bors: r+ rollup |
bors
commented
Jan 4, 2017
📌 Commit f05f9b1 has been approved by |
Fixes#38677
Sign formatting is no longer controlled by a
Signedtrait. Instead,pad_integralis used and implemented for numeric types by default.