Uh oh!
There was an error while loading. Please reload this page.
cargotest: Add xsv to tested crates - #38709
Merged
Merged
Conversation
This was intended to land in rust-lang#37149 but I ended up backing it out to land the rollup (rust-lang#38697) last night as I was itching to do so. This morning though xsv has been fixed now (BurntSushi/xsv#53) so we should be able to add it!
rust-highfive
commented
Dec 30, 2016
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Dec 30, 2016
MemberAuthor
cc @brson this is something I'd expect to have gotten caught by cargobomb? |
nikomatsakis
commented
Dec 30, 2016
Contributor
r=me I guess? :) Commit seems fine, but I dno't know a lot about the plans here. |
alexcrichton
commented
Dec 30, 2016
MemberAuthor
@bors: r=nikomatsakis I'll take it! |
bors
commented
Dec 30, 2016
Collaborator
📌 Commit 73b708a has been approved by |
bors
commented
Dec 30, 2016
Collaborator
⌛ Testing commit 73b708a with merge 82fdb4e... |
bors
commented
Dec 30, 2016
Collaborator
💔 Test failed - status-travis |
alexcrichton
commented
Dec 30, 2016
via email
MemberAuthor
@bors: retry …On Fri, Dec 30, 2016 at 2:43 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/187789726>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38709 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95M62cvz62a1nowti9W4k_3ecigprks5rNYkMgaJpZM4LYUAq>
.
|
brson
commented
Dec 31, 2016
Contributor
Yes cargobomb catches this. |
bors
commented
Dec 31, 2016
Collaborator
⌛ Testing commit 73b708a with merge ca0cc27... |
bors added a commit
that referenced
this pull request
Dec 31, 2016
cargotest: Add xsv to tested crates This was intended to land in #37149 but I ended up backing it out to land the rollup (#38697) last night as I was itching to do so. This morning though xsv has been fixed now (BurntSushi/xsv#53) so we should be able to add it!
bors
commented
Dec 31, 2016
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was intended to land in #37149 but I ended up backing it out to land the
rollup (#38697) last night as I was itching to do so. This morning though xsv
has been fixed now (BurntSushi/xsv#53) so we should be able to add it!