Skip to content

rustc: Stabilize the proc_macro feature - #38783

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:stabilize-proc-macro
Jan 4, 2017
Merged

rustc: Stabilize the proc_macro feature#38783
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:stabilize-proc-macro

Conversation

@alexcrichton

@alexcrichtonalexcrichton commented Jan 2, 2017

Copy link
Copy Markdown
Member

This commit stabilizes the proc_macro and proc_macro_lib features in the
compiler to stabilize the "Macros 1.1" feature of the language. Many more
details can be found on the tracking issue, #35900.

Closes#35900

@alexcrichton
rustc: Stabilize the proc_macro feature
045f8f6
This commit stabilizes the `proc_macro` and `proc_macro_lib` features in the
compiler to stabilize the "Macros 1.1" feature of the language. Many more
details can be found on the tracking issue, rust-lang#35900.
Closesrust-lang#35900
@rust-highfive

rust-highfive commented Jan 2, 2017

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik

steveklabnik commented Jan 2, 2017

Copy link
Copy Markdown
Contributor

🎊🎉

@alexcrichtonalexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 2, 2017
@abonander

abonander commented Jan 2, 2017

Copy link
Copy Markdown
Contributor

#[proc_macro_attribute] uses the proc_macro feature flag AFAICT; we don't want to stabilize a feature that's not even implemented yet, right? Is anyone working on that? If not, I've started tinkering with it.

@nikomatsakis

nikomatsakis commented Jan 3, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@nikomatsakis

nikomatsakis commented Jan 3, 2017

Copy link
Copy Markdown
Contributor

@bors r-

@nikomatsakis

nikomatsakis commented Jan 3, 2017

Copy link
Copy Markdown
Contributor

@abonander raises a good point! :) @alexcrichton, are there other users of proc_macro feature flag getting a free pass here?

@alexcrichton

alexcrichton commented Jan 3, 2017

Copy link
Copy Markdown
MemberAuthor

@abonander to clarify, is that implemented? I couldn't find proc_macro_attribute in the code base currently at least...

@nikomatsakis AFAIK nothing else is, no

@abonander

abonander commented Jan 3, 2017

Copy link
Copy Markdown
Contributor

I've started tinkering on it because I'd like to experiment with the feature. It actually looks pretty straightforward, mostly just copying custom derive.

@alexcrichton

alexcrichton commented Jan 3, 2017

Copy link
Copy Markdown
MemberAuthor

@abonander I'm still a little confused? I haven't been following all the proc-macro business that closely. What is proc_macro_attribute? Is it implemented today? Does this PR need to change?

@abonander

abonander commented Jan 3, 2017

Copy link
Copy Markdown
Contributor

rust-lang/rfcs#1566

It is not currently supported in the compiler, though the pieces are (mostly) there. I'd have to read over the RFC again but I don't think it uses its own feature flag, though that can be changed trivially.

@alexcrichton

alexcrichton commented Jan 3, 2017

Copy link
Copy Markdown
MemberAuthor

Ok, sounds like that can just have a new feature gate if it isn't already implemented? I'm sort of confused, does this PR need to change?

@abonander

abonander commented Jan 3, 2017

Copy link
Copy Markdown
Contributor

I don't think so, we just need to make sure the feature gate for the other two proc macro kinds is different.

@nikomatsakis

nikomatsakis commented Jan 4, 2017

Copy link
Copy Markdown
Contributor

@bors r+ p=1

@bors

bors commented Jan 4, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 045f8f6 has been approved by nikomatsakis

@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 4, 2017
@nikomatsakis

nikomatsakis commented Jan 4, 2017

Copy link
Copy Markdown
Contributor

Marking as beta-accepted. The whole point is to backport this -- and anyway it's 99% marking stuff stable.

cc @rust-lang/compiler

@bors

bors commented Jan 4, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 045f8f6 with merge 95b14a3...

bors added a commit that referenced this pull request Jan 4, 2017
@bors
Auto merge of#38783- alexcrichton:stabilize-proc-macro, r=nikomatsakis
95b14a3
rustc: Stabilize the `proc_macro` feature
This commit stabilizes the `proc_macro` and `proc_macro_lib` features in the
compiler to stabilize the "Macros 1.1" feature of the language. Many more
details can be found on the tracking issue, #35900.
Closes#35900
@bors

bors commented Jan 4, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 95b14a3 to master...

@bors
bors merged commit 045f8f6 into rust-lang:masterJan 4, 2017
This was referenced Jan 4, 2017
Merged
Closed
@nikomatsakisnikomatsakis mentioned this pull request Jan 6, 2017
Merged
17 tasks
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 6, 2017
@jseyfriedjseyfried mentioned this pull request Jan 9, 2017
Merged
@alexcrichton
alexcrichton deleted the stabilize-proc-macro branch January 13, 2017 23:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@steveklabniksteveklabniksteveklabnik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@aturonaturon

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alexcrichton@rust-highfive@steveklabnik@abonander@nikomatsakis@bors@aturon