Uh oh!
There was an error while loading. Please reload this page.
fix help for the --print option - #38815
Merged
Merged
Conversation
Since 8285ab5, which was merged in with rust-lang#38061, the help for the --print option is missing the surrounding [ ] around the possible options. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
rust-highfive
commented
Jan 4, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
nikomatsakis
commented
Jan 4, 2017
Contributor
@bors r+ rollup Thanks! :) |
bors
commented
Jan 4, 2017
Collaborator
📌 Commit 031dd81 has been approved by |
cardoe
commented
Jan 4, 2017
ContributorAuthor
@nikomatsakis Not sure if you want to pull this into the beta since this is a UI break. |
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Jan 4, 2017
fix help for the --print option Since 8285ab5, which was merged in with rust-lang#38061, the help for the --print option is missing the surrounding [ ] around the possible options. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
nikomatsakis
commented
Jan 5, 2017
Contributor
Nominated for beta. Seems like a harmless backport. cc @rust-lang/compiler |
cardoe
commented
Jan 5, 2017
ContributorAuthor
FWIW, the output in 1.14.0 is correct. So backporting the fix to beta would cause no user visible regression to occur in a stable release. |
nikomatsakis
commented
Jan 6, 2017
Contributor
Accepting for beta. Harmless. cc @rust-lang/compiler |
nikomatsakis
commented
Jan 6, 2017
Contributor
@bors rollup- |
nikomatsakis
commented
Jan 6, 2017
Contributor
@bors p=1
|
bors
commented
Jan 6, 2017
Collaborator
bors
commented
Jan 6, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 8285ab5, which was merged in with #38061, the help for the
--print option is missing the surrounding [ ] around the possible
options.
Signed-off-by: Doug Goldstein cardoe@cardoe.com