Skip to content

resolve: don't unused_qualifications-check global paths - #38817

Merged
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:improve_unused_qualification_lint
Jan 5, 2017
Merged

resolve: don't unused_qualifications-check global paths#38817
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:improve_unused_qualification_lint

Conversation

@jseyfried

@jseyfriedjseyfried commented Jan 4, 2017

Copy link
Copy Markdown
Contributor

We started unused_qualifications-checking global paths in #38014, causing #38682.
Fixes#38682.
r? @nrc

@jseyfried

jseyfried commented Jan 4, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

The macros 1.1 system currently not provide enough span info to unused_qualifications-check only unexpanded global paths.
Improving the span info enough to fix this is doable but I'd rather we not have to backport it.

@jseyfriedjseyfried mentioned this pull request Jan 4, 2017
Closed
@petrochenkov

petrochenkov commented Jan 4, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jan 4, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 7dcacf1 has been approved by petrochenkov

@jseyfriedjseyfried added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2017
@killercup

killercup commented Jan 4, 2017

Copy link
Copy Markdown
Contributor

FYI this could also fix #38444 (which is already closed)

@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 4, 2017
@nikomatsakis

nikomatsakis commented Jan 4, 2017

Copy link
Copy Markdown
Contributor

Accepted for beta. Small patch, regression. cc @rust-lang/compiler

@alexcrichton

alexcrichton commented Jan 4, 2017

Copy link
Copy Markdown
Member

@bors: p=1

(this is approved, we'll want to backport)

@bors

bors commented Jan 5, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7dcacf1 with merge a39fc9c...

@bors

bors commented Jan 5, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Jan 5, 2017 via email

Copy link
Copy Markdown
Member

@bors

bors commented Jan 5, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7dcacf1 with merge a10ce81...

@bors

bors commented Jan 5, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Jan 5, 2017 via email

Copy link
Copy Markdown
Member

@bors

bors commented Jan 5, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7dcacf1 with merge cdd72e7...

@bors

bors commented Jan 5, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@nikomatsakis

nikomatsakis commented Jan 5, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

@bors retry

  • odd timeouts building LLVM?

@bors

bors commented Jan 5, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7dcacf1 with merge ea2d41e...

bors added a commit that referenced this pull request Jan 5, 2017
@bors
Auto merge of#38817- jseyfried:improve_unused_qualification_lint, r…
ea2d41e
…=petrochenkov
resolve: don't `unused_qualifications`-check global paths
We started `unused_qualifications`-checking global paths in #38014, causing #38682.
Fixes#38682.
r? @nrc
@bors

bors commented Jan 5, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing ea2d41e to master...

@bors
bors merged commit 7dcacf1 into rust-lang:masterJan 5, 2017
@nikomatsakisnikomatsakis mentioned this pull request Jan 6, 2017
Merged
17 tasks
@jseyfried
jseyfried deleted the improve_unused_qualification_lint branch January 6, 2017 18:23
@alexcrichtonalexcrichton mentioned this pull request Jan 7, 2017
Merged
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 7, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrcnrc

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jseyfried@petrochenkov@bors@killercup@nikomatsakis@alexcrichton@nrc