Uh oh!
There was an error while loading. Please reload this page.
fix function arguments in constant promotion - #38989
Merged
Merged
Conversation
we can't create the target block until *after* we promote the arguments - otherwise the arguments will be promoted into the target block. oops. Fixesrust-lang#38985.
eddyb
commented
Jan 11, 2017
Contributor
@bors r+ |
bors
commented
Jan 11, 2017
Collaborator
📌 Commit 61b0b21 has been approved by |
bors
commented
Jan 11, 2017
Collaborator
bors added a commit
that referenced
this pull request
Jan 11, 2017
fix function arguments in constant promotion we can't create the target block until *after* we promote the arguments - otherwise the arguments will be promoted into the target block. oops. Fixes#38985. This is a regression introduced in the beta-nominated #38833, so beta-nominating this one too (sorry @brson). r? @eddyb
bors
commented
Jan 11, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
brson
commented
Jan 17, 2017
Contributor
Thanks @arielb1 ! |
brson
commented
Jan 17, 2017
Contributor
Accepted stable bug fix low impact. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we can't create the target block until after we promote the arguments - otherwise the arguments will be promoted into the target block. oops.
Fixes#38985.
This is a regression introduced in the beta-nominated #38833, so beta-nominating this one too (sorry @brson).
r? @eddyb