Skip to content

Improve the warning cycle for use $crate; - #39077

Merged
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:crate_var_imports
Jan 21, 2017
Merged

Improve the warning cycle for use $crate;#39077
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:crate_var_imports

Conversation

@jseyfried

Copy link
Copy Markdown
Contributor

Fixes#39049.
r? @nrc

@jseyfriedjseyfried added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 15, 2017
@nrc

nrc commented Jan 17, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Jan 17, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit c02d577 has been approved by nrc

@brsonbrson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 17, 2017
@brson

Copy link
Copy Markdown
Contributor

Accepting for backport assuming it cherry-picks.

@brsonbrson mentioned this pull request Jan 17, 2017
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 17, 2017
@jseyfriedjseyfried mentioned this pull request Jan 17, 2017
@bors

bors commented Jan 20, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c02d577 with merge 58293d8...

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 20, 2017
@alexcrichton

Copy link
Copy Markdown
Member

@bors: retry

  • prioritizing rollup

bors added a commit that referenced this pull request Jan 20, 2017
bors added a commit that referenced this pull request Jan 21, 2017
@bors
bors merged commit c02d577 into rust-lang:masterJan 21, 2017
@bors

bors commented Jan 21, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c02d577 with merge aedb49c...

@jseyfried
jseyfried deleted the crate_var_imports branch January 24, 2017 12:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jseyfried@nrc@bors@brson@alexcrichton