Uh oh!
There was an error while loading. Please reload this page.
rustbuild: Start building --enable-extended - #39245
Merged
Merged
Conversation
alexcrichtonforce-pushed
the
enable-platform
branch
6 times, most recently
from
January 23, 2017 21:56
3560665 to
df0fb17Comparealexcrichton
commented
Jan 23, 2017
MemberAuthor
@brson ok I've updated with support for Windows as well, this should be good to go. |
alexcrichtonforce-pushed
the
enable-platform
branch
2 times, most recently
from
January 23, 2017 23:36
e5391f9 to
3e6065fComparebrson
reviewed
Jan 24, 2017
brson
commented
Jan 24, 2017
Contributor
This all looks great, but can we get rid of the 'platform' branding? How about r=me |
alexcrichtonforce-pushed
the
enable-platform
branch
from
January 24, 2017 01:09
3e6065f to
e0c0368Comparealexcrichton
commented
Jan 24, 2017
MemberAuthor
@bors: r=brson |
bors
commented
Jan 24, 2017
Collaborator
📌 Commit e0c0368 has been approved by |
bors
commented
Jan 24, 2017
Collaborator
⌛ Testing commit e0c0368 with merge b69cb4b... |
bors
commented
Jan 24, 2017
Collaborator
💔 Test failed - status-travis |
alexcrichton
commented
Jan 24, 2017
MemberAuthor
@bors: r=brson |
bors
commented
Jan 24, 2017
Collaborator
💡 This pull request was already approved, no need to approve it again.
|
bors
commented
Jan 24, 2017
Collaborator
📌 Commit e0c0368 has been approved by |
alexcrichtonforce-pushed
the
enable-platform
branch
from
January 24, 2017 16:54
e0c0368 to
3a31aabComparealexcrichton
commented
Jan 24, 2017
MemberAuthor
@bors: r=brson |
bors
commented
Jan 24, 2017
Collaborator
📌 Commit 3a31aab has been approved by |
bors
commented
Jan 24, 2017
Collaborator
bors added a commit
that referenced
this pull request
Jan 24, 2017
rustbuild: Start building --enable-extended This commit adds a new flag to the configure script, `--enable-extended`, which is intended for specifying a desire to compile the full suite of Rust tools such as Cargo, the RLS, etc. This is also an indication that the build system should create combined installers such as the pkg/exe/msi artifacts. Currently the `--enable-extended` flag just indicates that combined installers should be built, and Cargo is itself not compiled just yet but rather only downloaded from its location. The intention here is to quickly get to feature parity with the current release process and then we can start improving it afterwards. All new files in this PR inside `src/etc/installer` are copied from the rust-packaging repository. cc #38531
bors
commented
Jan 24, 2017
Collaborator
💔 Test failed - status-travis |
This commit adds a new flag to the configure script, `--enable-extended`, which is intended for specifying a desire to compile the full suite of Rust tools such as Cargo, the RLS, etc. This is also an indication that the build system should create combined installers such as the pkg/exe/msi artifacts. Currently the `--enable-extended` flag just indicates that combined installers should be built, and Cargo is itself not compiled just yet but rather only downloaded from its location. The intention here is to quickly get to feature parity with the current release process and then we can start improving it afterwards. All new files in this PR inside `src/etc/installer` are copied from the rust-packaging repository.
alexcrichtonforce-pushed
the
enable-platform
branch
from
January 24, 2017 22:48
3a31aab to
f3dfcaeComparealexcrichton
commented
Jan 24, 2017
MemberAuthor
@bors: r=brson |
bors
commented
Jan 24, 2017
Collaborator
📌 Commit f3dfcae has been approved by |
bors
commented
Jan 24, 2017
Collaborator
bors added a commit
that referenced
this pull request
Jan 24, 2017
rustbuild: Start building --enable-extended This commit adds a new flag to the configure script, `--enable-extended`, which is intended for specifying a desire to compile the full suite of Rust tools such as Cargo, the RLS, etc. This is also an indication that the build system should create combined installers such as the pkg/exe/msi artifacts. Currently the `--enable-extended` flag just indicates that combined installers should be built, and Cargo is itself not compiled just yet but rather only downloaded from its location. The intention here is to quickly get to feature parity with the current release process and then we can start improving it afterwards. All new files in this PR inside `src/etc/installer` are copied from the rust-packaging repository. cc #38531
38 tasks
bors
commented
Jan 25, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new flag to the configure script,
--enable-extended, which is intended for specifying a desire tocompile the full suite of Rust tools such as Cargo, the RLS, etc. This
is also an indication that the build system should create combined
installers such as the pkg/exe/msi artifacts.
Currently the
--enable-extendedflag just indicates that combinedinstallers should be built, and Cargo is itself not compiled just yet
but rather only downloaded from its location. The intention here is to
quickly get to feature parity with the current release process and then
we can start improving it afterwards.
All new files in this PR inside
src/etc/installerare copied from therust-packaging repository.
cc #38531