Uh oh!
There was an error while loading. Please reload this page.
Highlight code in rustc --explain (WIP) - #39300
Conversation
rust-highfive
commented
Jan 25, 2017
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
estebank
commented
Jan 25, 2017
Not ready for merging yet: It doesn't check wether the output can actually support color codes. Piping to other tools will cause control characters to be displayed: $ rustc --explain E0038 > file.txt && more file.txt
(...)
```
ESC[33mtraitESC(BESC[m ESC(BESC[mFooESC(BESC[m ESC(BESC[mESC[33mwhereESC(BESC[m ESC(BESC[mESC[36mSelfESC(BESC[m:ESC(BESC[m ESC(BESC[mSizedESC(BESC[m ESC(BESC[m{ESC(BESC[m
ESC(BESC[m}ESC(BESC[m
ESC(BESC[m```
(...)
|
bors
commented
Feb 4, 2017
☔ The latest upstream changes (presumably #39463) made this pull request unmergeable. Please resolve the merge conflicts. |
rustc --explainrustc --explain (WIP)pnkfelix
commented
Mar 6, 2017
@estebank any status update here? Should I close this PR? |
estebank
commented
Mar 7, 2017
@pnkfelix I've been offline for two weeks and haven't had a chance to clean this up for submission (it's lacking detection of pipe vs stdout output). Regardless, could you advice on the changes that were made already, in order to know wether they're in the right track? |
pnkfelix
commented
Mar 20, 2017
@estebank I'm not clear on whether we can just add new dependencies to |
estebank
commented
Mar 20, 2017
@pnkfelix this PR didn't introduce any external crates, it moved existing code into its own crate. I'll try to get back to this PR this Saturday to clean it up for merging. |
alexcrichton
commented
Apr 1, 2017
Closing due to inactivity, but feel free to resubmit with a rebase! (seems like a nifty addition!) |
Internals thread.
New output: