Uh oh!
There was an error while loading. Please reload this page.
Remove obsolete documentation about drop-flags - #39304
Conversation
rust-highfive
commented
Jan 25, 2017
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
This "no longer" bit doesn't make much sense since you removed the part that it references. Maybe keep a condensed version so it's more like "This is how it was in Rust 1.0, then in 1.13 it changed to this."?
There was a problem hiding this comment.
I'd prefer to lead with the current behaviour.
How about:
As of Rust 1.13, the drop flags are now tracked on the stack instead of being stashed in types that implement drop as they were in prior versions.
There was a problem hiding this comment.
We don't mention versions in docs; always speak to the present.
There was a problem hiding this comment.
(so just lose the first clause)
There was a problem hiding this comment.
(so just lose the first clause)
steveklabnik
commented
Feb 7, 2017
ping @jrmuizel ! Any interest in keeping this going? |
bors
commented
Feb 15, 2017
☔ The latest upstream changes (presumably #39633) made this pull request unmergeable. Please resolve the merge conflicts. |
steveklabnik
commented
Feb 15, 2017
@jrmuizel sorry, I did not see that you pushed a commit. Mind rebasing this one last time? It should be good to go then |
jrmuizel
commented
Feb 15, 2017
Done. |
steveklabnik
commented
Feb 20, 2017
@bors: r+ rollup |
bors
commented
Feb 20, 2017
📌 Commit 4ba6e1b has been approved by |
bors
commented
Feb 20, 2017
⌛ Testing commit 4ba6e1b with merge 08eea7a... |
steveklabnik
commented
Feb 20, 2017
@bors: retry |
bors
commented
Feb 20, 2017
Remove obsolete documentation about drop-flags
bors
commented
Feb 20, 2017
☀️ Test successful - status-appveyor, status-travis |
No description provided.