Resolve a bunch of fixmes

[wesleywiser]

Resolves 56 fixmes in test code related to box syntax.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[petrochenkov]

If I remember correctly, "when/if possible" == "box is stabilized" in these FIXMEs.
cc #23002@pnkfelix

[alexcrichton]

Thanks for the PR @wesleywiser I wonder though if we could perhaps avoid adding #![feature(box_syntax)] where not already specified and perhaps just delete the FIXME as the bug has already been fixed?

[wesleywiser]

@petrochenkov My understanding from reading #22405 was that the issue was not being able to infer the result of box {expr} in various cases. This no longer seems to be the case since the tests compile.

@alexcrichton Sure I can do that. What do you think of @petrochenkov's comment? Does this need to wait for box stabilization?

[alexcrichton]

Oh well it seems that the motivation/purpose of this PR is to remove these FIXME annotations. I don't think the FIXME annotations need to literally be changed to use box as it's not stable, and the relevant bug appears to have been fixed. In that sense the FIXME annotations themselves aren't too useful any more so we can just delete them without changing over to using box.

I personally prefer to favor stable features wherever possible, so that's just my own personal preference for deleting outright instead of deleting and switching to box

[wesleywiser]

Easy enough! I'll push a new commit that simply removes the FIXMEs for this particular issue with no other changes.

[bors]

☔ The latest upstream changes (presumably #39230) made this pull request unmergeable. Please resolve the merge conflicts.

[alexcrichton]

@wesleywiser looks like there's a pretty test failure on Travis?

[wesleywiser]

Thanks! I'll look into that tomorrow.

…

On Mon, Jan 30, 2017, 11:17 PM Alex Crichton ***@***.***> wrote: @wesleywiser <https://github.com/wesleywiser> looks like there's a pretty test failure on Travis? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39384 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAyu2EEg5ylEWHvD_iMTqpo99RXfc32Dks5rXrXogaJpZM4LwuK9> .

[wesleywiser]

@alexcrichton It should be fixed now. It looks like two of the Mac Travis bots failed trying to clone the repo and the other two have been stuck trying to clone for a few hours now. All of the other bots have passed.

[GuillaumeGomez]

Are we burying the box syntax?! 😨

[ghost]

There is a lot of places in the compiler where unstable features are being used, removing only the FIXME without using that lang item feels like a step backward, since this won't help pushing that feature out of the unstable zone.

[alexcrichton]

@bors: r+

Thanks @wesleywiser!

@Michael-Zapata these comments are all ancient and the bugs have all been fixed anyway, so I don't think we're going backwards here at all.

[bors]

📌 Commit 94687aa has been approved by alexcrichton

[bors]

⌛ Testing commit 94687aa with merge 7234e5c...

[alexcrichton]

@bors: retry

• there was an osx linker segfault (OSX linker segfaulting on Travis #38878) on travis but bors may not have gotten the notification, retrying to see if we can kick everything back into action

[bors]

⌛ Testing commit 94687aa with merge 3b24c70...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 3b24c70 to master...