Conversions between slices and boxes by clarfonthey · Pull Request #39438 · rust-lang/rust

clarfonthey · 2017-02-01T03:48:52Z

This allows conversion for Copy slices, str, and CStr into their boxed counterparts.

This also adds the method CString::into_boxed_c_str.

I would like to add similar implementations for OsStr as well, but I have not figured out how.

rust-highfive · 2017-02-01T03:48:57Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

aturon · 2017-02-01T18:56:10Z

Since these impls are instantly stable, we need the full libs team to sign off.

Personally, I think that we will continue growing such impls until the end of time. Due to trait coherence, std is the only place such impls can live. So I'm fine continuing to sign off on such PRs.

@rfcbot fcp merge

aturon · 2017-02-01T18:56:34Z

Whoops, didn't have the libs team assigned first, trying again:

@rfcbot fcp merge

rfcbot · 2017-02-01T18:56:35Z

Team member @aturon has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

clarfonthey · 2017-02-01T19:40:58Z

Reminder to self for later: also add versions for CStr and OsStr

alexcrichton · 2017-02-04T22:38:02Z

@clarcharr the compile failures here seem worrisome, they may want to be fixed!

clarfonthey · 2017-02-04T22:50:13Z

@alexcrichton I'll fix those soon; I know what's wrong.

Instead of using Vec and String I'll have to do it manually.

clarfonthey · 2017-02-05T00:39:59Z

Waiting on tests, but this should work now. I also added an implementation for CStr and added a new method, CString::into_boxed_c_str, which will need a tracking issue once I get an informal nod that such a method is okay to add.

alexcrichton · 2017-02-06T19:19:08Z

@clarcharr perhaps the CStr parts could be left out for a future PR? Unfortunately trait impls are instantly stable today and we don't have much other precedent with that type and DST impls, so we may just wish to conservatively tackle it in a separate PR

clarfonthey · 2017-02-06T19:34:52Z

Sounds good to me! I'll split them out and open another PR.

clarfonthey · 2017-02-08T04:02:03Z

@malbarbo That's because it's more efficient if the type implements Copy, but I could make a more general version using impl specialisation. If you think it's worth having, feel free to open an issue and I might get around to it!

malbarbo · 2017-02-08T09:47:24Z

@clarcharr You can use Vec::from_iter, it is already specialized for copy types https://doc.rust-lang.org/stable/src/collections/vec.rs.html#1499-1670

clarfonthey · 2017-02-08T15:47:33Z

@malbarbo right now that'll work for .to_vec().into_boxed_slice(), but not directly like in these conversions. I'll take a look at it in my other PR.

clarfonthey · 2017-02-10T06:17:45Z

So apparently this didn't get merged? Did I miss something?

bors · 2017-02-10T07:26:39Z

⌛ Testing commit 550373b with merge 8482c4b...

bjorn3 · 2017-02-10T07:28:17Z

@clarcharr The rollup pr failed, so you will have to wait till the next rollup. (Got a pr of mine merged after 6 rollup prs)

bors · 2017-02-10T08:40:35Z

💔 Test failed - status-appveyor

alexcrichton · 2017-02-10T15:03:53Z

@bors: retry * #38620

…

On Fri, Feb 10, 2017 at 12:40 AM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang/rust/build/1.0.1883> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39438 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95C5k6K2gP7Th6wU9oi22LPWVIz9Kks5rbCKFgaJpZM4LzdpA> .

Conversions between slices and boxes This allows conversion for `Copy` slices, `str`, and `CStr` into their boxed counterparts. This also adds the method `CString::into_boxed_c_str`. I would like to add similar implementations for `OsStr` as well, but I have not figured out how.

bors · 2017-02-10T17:14:14Z

⌛ Testing commit 550373b with merge 16f5492...

bors · 2017-02-10T18:38:04Z

💔 Test failed - status-travis

bjorn3 · 2017-02-10T19:18:51Z

dist-mips-linux:

[...]
[ 83%] Built target LLVMMSP430Info
Scanning dependencies of target LLVMMSP430Desc
[ 83%] Building CXX object lib/Target/MSP430/MCTargetDesc/CMakeFiles/LLVMMSP430Desc.dir/MSP430MCTargetDesc.cpp.o
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

alexcrichton · 2017-02-10T19:20:00Z

@bors: retry * sccache wedged #39003

…

On Fri, Feb 10, 2017 at 11:18 AM, bjorn3 ***@***.***> wrote: dist-mips-linux: [...] [ 83%] Built target LLVMMSP430Info Scanning dependencies of target LLVMMSP430Desc [ 83%] Building CXX object lib/Target/MSP430/MCTargetDesc/CMakeFiles/LLVMMSP430Desc.dir/MSP430MCTargetDesc.cpp.o No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received The build has been terminated — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39438 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95D926SXesz_zCfgWxi0pvlElq3ccks5rbLgdgaJpZM4LzdpA> .

bors · 2017-02-10T19:58:13Z

⌛ Testing commit 550373b with merge 99b6677...

bors · 2017-02-10T21:03:06Z

💔 Test failed - status-travis

alexcrichton · 2017-02-10T21:07:13Z

@bors: retry

flaky thread sanitizer test? (guessing)

@japaric does that look familiar? We may have to disable the test if it ends up being flaky :(

bors · 2017-02-10T21:11:33Z

⌛ Testing commit 550373b with merge 2425b22...

Conversions between slices and boxes This allows conversion for `Copy` slices, `str`, and `CStr` into their boxed counterparts. This also adds the method `CString::into_boxed_c_str`. I would like to add similar implementations for `OsStr` as well, but I have not figured out how.

bors · 2017-02-10T23:50:41Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 2425b22 to master...

japaric · 2017-02-12T23:37:49Z

@alexcrichton Sadly, no. I haven't seen the thread sanitizer not catch that data race before. I'll test locally to see if I can repro.

rust-highfive assigned aturon Feb 1, 2017

aturon added the T-libs-api [DEPRECATED; DO NOT USE] label Feb 1, 2017

clarfonthey force-pushed the box_from branch from 12adaa2 to 0d74fc3Compare February 5, 2017 00:37

clarfonthey changed the title ~~Implement From<&str> and From<&[T]> for Box~~Conversions between slices and boxesFeb 5, 2017

clarfonthey force-pushed the box_from branch 12 times, most recently from 69e4ee6 to 7b71cd1Compare February 6, 2017 18:25

clarfonthey force-pushed the box_from branch from 7b71cd1 to afb535cCompare February 6, 2017 20:23

clarfonthey mentioned this pull request Feb 6, 2017
Conversions between CStr, OsStr, Path and boxes #39594
Merged

Direct conversions between slices and boxes.
550373b

clarfonthey force-pushed the box_from branch from afb535c to 550373bCompare February 6, 2017 23:53

clarfonthey closed this Feb 8, 2017

clarfonthey deleted the box_from branch February 8, 2017 03:40

clarfonthey restored the box_from branch February 10, 2017 06:17

clarfonthey reopened this Feb 10, 2017

frewsxcv mentioned this pull request Feb 10, 2017
Rollup of 5 pull requests #39718
Closed

bors merged commit 550373b into rust-lang:masterFeb 10, 2017

Uh oh!

Uh oh!

Conversation

clarfonthey commented Feb 1, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Feb 1, 2017

Uh oh!

aturon commented Feb 1, 2017

Uh oh!

aturon commented Feb 1, 2017

Uh oh!

rfcbot commented Feb 1, 2017• edited by Kimundi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clarfonthey commented Feb 1, 2017

Uh oh!

alexcrichton commented Feb 4, 2017

Uh oh!

clarfonthey commented Feb 4, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clarfonthey commented Feb 5, 2017

Uh oh!

alexcrichton commented Feb 6, 2017

Uh oh!

clarfonthey commented Feb 6, 2017

Uh oh!

clarfonthey commented Feb 8, 2017

Uh oh!

malbarbo commented Feb 8, 2017

Uh oh!

clarfonthey commented Feb 8, 2017

Uh oh!

clarfonthey commented Feb 10, 2017

Uh oh!

bors commented Feb 10, 2017

Uh oh!

bjorn3 commented Feb 10, 2017

Uh oh!

bors commented Feb 10, 2017

Uh oh!

alexcrichton commented Feb 10, 2017 via email

Uh oh!

bors commented Feb 10, 2017

Uh oh!

bors commented Feb 10, 2017

Uh oh!

bjorn3 commented Feb 10, 2017

Uh oh!

alexcrichton commented Feb 10, 2017 via email

Uh oh!

bors commented Feb 10, 2017

Uh oh!

bors commented Feb 10, 2017

Uh oh!

alexcrichton commented Feb 10, 2017

Uh oh!

bors commented Feb 10, 2017

Uh oh!

bors commented Feb 10, 2017

Uh oh!

japaric commented Feb 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

clarfonthey commented Feb 1, 2017•
edited
Loading

rfcbot commented Feb 1, 2017•
edited by Kimundi
Loading

clarfonthey commented Feb 4, 2017•
edited
Loading