suggest doubling recursion limit in more situations by durka · Pull Request #39655 · rust-lang/rust

durka · 2017-02-08T22:07:18Z

durka · 2017-02-08T22:08:00Z

This duplicate error shouldn't be here and yet it is. cc #38940 @jseyfried

durka · 2017-02-28T09:12:26Z

r?

bluss · 2017-02-28T09:49:18Z

+ ei.callee.name()));
+ err.note(&format!(
+ "consider adding a `#![recursion_limit=\"{}\"]` attribute to your crate",
+ suggested_limit));


Can this be .help() too or is there a reason it can't?

Yes, I think it can be.

bluss · 2017-02-28T18:50:40Z

This will need update to help I think

bluss · 2017-02-28T18:50:46Z

Thanks. I'll ~~approve this after~~ checking with rustc devs

eddyb · 2017-02-28T18:52:59Z

r? @nikomatsakis

nikomatsakis · 2017-02-28T20:57:04Z

maybe we should factor this code into some sort of helper?

I feel like it'd also be nice to make this into an error code ("recursion limit reached") with a note giving the specific details. That way, we could give an extended error description.

Where should I put the helper and diagnostic code? Note that the PR is split across libsyntax and librustc_typeck.

Hmm. Can we only put diagnostic codes into rustc crates? I'm not sure.

There are diagnostic codes in libsyntax. Can I define it there and use the same one from librustc_typeck?

Meh. I think we should improve this, but it's not that big a deal.

nikomatsakis · 2017-03-01T23:29:57Z

@bors r+

bors · 2017-03-01T23:29:58Z

📌 Commit e1773cb has been approved by nikomatsakis

bors · 2017-03-02T06:14:28Z

⌛ Testing commit e1773cb with merge f46ed40...

bors · 2017-03-02T06:58:36Z

💔 Test failed - status-appveyor

durka · 2017-03-02T07:11:47Z

Should be fixed.

bluss · 2017-03-02T14:28:05Z

@bors r=nikomatsakis

bors · 2017-03-02T14:28:07Z

📌 Commit 6e259dc has been approved by nikomatsakis

bors · 2017-03-02T16:43:41Z

⌛ Testing commit 6e259dc with merge 907f26d...

@bluss

…=nikomatsakis suggest doubling recursion limit in more situations Fixesrust-lang#38852. r? @bluss

frewsxcv · 2017-03-02T17:00:32Z

@bors retry

bors · 2017-03-02T17:44:21Z

⌛ Testing commit 6e259dc with merge 5907ed6...

@bluss

suggest doubling recursion limit in more situations Fixes#38852. r? @bluss

bors · 2017-03-02T20:10:35Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 5907ed6 to master...

rust-highfive assigned bluss Feb 8, 2017

durka commented Feb 8, 2017
View reviewed changes

durka force-pushed the recursion-limit-suggestion branch 2 times, most recently from fbaef50 to 422b789Compare February 9, 2017 06:35

suggest doubling recursion limit in more situations
b4993ec

durka force-pushed the recursion-limit-suggestion branch from 422b789 to b4993ecCompare February 9, 2017 06:40

bluss reviewed Feb 28, 2017
View reviewed changes

Comment threadsrc/test/ui/did_you_mean/recursion_limit.stderr Outdated
blussFeb 28, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need update to help I think

durka force-pushed the recursion-limit-suggestion branch from 80cd3cf to e1773cbCompare February 28, 2017 18:57

rust-highfive assigned nikomatsakis and unassigned bluss Feb 28, 2017

nikomatsakis reviewed Feb 28, 2017
View reviewed changes

durka mentioned this pull request Mar 1, 2017
consolidate recursion limit errors #40198
Open

note -> help
6e259dc

durka force-pushed the recursion-limit-suggestion branch from e1773cb to 6e259dcCompare March 2, 2017 07:11

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 2, 2017
Rollup merge ofrust-lang#39655- durka:recursion-limit-suggestion, r…
afb9831
…=nikomatsakis suggest doubling recursion limit in more situations Fixesrust-lang#38852. r? @bluss

frewsxcv mentioned this pull request Mar 2, 2017
Rollup of 6 pull requests #40211
Closed

bors added a commit that referenced this pull request Mar 2, 2017
Auto merge of#39655- durka:recursion-limit-suggestion, r=nikomatsakis
5907ed6
suggest doubling recursion limit in more situations Fixes#38852. r? @bluss

bors merged commit 6e259dc into rust-lang:masterMar 2, 2017

durka mentioned this pull request Mar 15, 2017
error for recursion limit should give instructions for increasing it #34565
Closed

Uh oh!

Uh oh!

Conversation

durka commented Feb 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

durka commented Feb 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bluss commented Feb 28, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eddyb commented Feb 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Mar 1, 2017

Uh oh!

bors commented Mar 1, 2017

Uh oh!

bors commented Mar 2, 2017

Uh oh!

bors commented Mar 2, 2017

Uh oh!

durka commented Mar 2, 2017

Uh oh!

bluss commented Mar 2, 2017

Uh oh!

bors commented Mar 2, 2017

Uh oh!

bors commented Mar 2, 2017

Uh oh!

frewsxcv commented Mar 2, 2017

Uh oh!

bors commented Mar 2, 2017

Uh oh!

bors commented Mar 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bluss commented Feb 28, 2017•
edited
Loading