Uh oh!
There was an error while loading. Please reload this page.
Delete more swaths of the configure script - #39770
Merged
Merged
Conversation
rust-highfive
commented
Feb 12, 2017
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
Feb 25, 2017
Collaborator
☔ The latest upstream changes (presumably #40091) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichtonforce-pushed
the
configure-clean
branch
from
February 25, 2017 22:46
070bd28 to
bfd2f5bComparebrson
reviewed
Mar 9, 2017
| elif cputype == 's390x': | ||
| cputype = 's390x' | ||
| elif cputype == 'BePC': | ||
| cputype = 'i686' |
Contributor
There was a problem hiding this comment.
'BePC' really? where did this come from?
MemberAuthor
There was a problem hiding this comment.
Oh I run Haiku at home and Rust won't bootstrap otherwise.
brson
commented
Mar 9, 2017
Contributor
@bors r+ |
bors
commented
Mar 9, 2017
Collaborator
📌 Commit bfd2f5b has been approved by |
bors
commented
Mar 10, 2017
Collaborator
🔒 Merge conflict |
alexcrichton
commented
Mar 10, 2017
MemberAuthor
@bors: retry |
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 10, 2017
Delete more swaths of the configure script This PR deletes more swaths of the `./configure` script which are either no longer necessary or already available in rustbuild (where an implementation is preferred)
alexcrichtonforce-pushed
the
configure-clean
branch
from
March 10, 2017 15:59
bfd2f5b to
cd23f1cComparealexcrichton
commented
Mar 10, 2017
MemberAuthor
@bors: r=brson |
bors
commented
Mar 10, 2017
Collaborator
📌 Commit cd23f1c has been approved by |
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 10, 2017
Delete more swaths of the configure script This PR deletes more swaths of the `./configure` script which are either no longer necessary or already available in rustbuild (where an implementation is preferred)
alexcrichtonforce-pushed
the
configure-clean
branch
from
March 10, 2017 21:00
cd23f1c to
3acaf21Comparealexcrichton
commented
Mar 10, 2017
MemberAuthor
@bors: r=brson |
bors
commented
Mar 10, 2017
Collaborator
📌 Commit 3acaf21 has been approved by |
alexcrichtonforce-pushed
the
configure-clean
branch
from
March 10, 2017 21:01
3acaf21 to
ade8f29Comparealexcrichton
commented
Mar 10, 2017
MemberAuthor
@bors: r=brson |
bors
commented
Mar 10, 2017
Collaborator
📌 Commit ade8f29 has been approved by |
bors
commented
Mar 11, 2017
Collaborator
☔ The latest upstream changes (presumably #40432) made this pull request unmergeable. Please resolve the merge conflicts. |
This is all in rustbuild already.
This is all not used any more
All of these should be handled by rustbuild in sanity.rs right now.
All of this should already be vendored in rustbuild if necessary or otherwise it's just not used.
This is not used any more
None of this is used by rustbuild any more
This commit removes detection of CFG_OSTYPE and CFG_CPUTYPE from the configure script, which means that the default value of `--build` is no longer present in the configure script. All this logic is now available in rustbuild itself, so there's no need to duplicate it.
alexcrichtonforce-pushed
the
configure-clean
branch
from
March 11, 2017 16:41
ade8f29 to
f8ca805Comparealexcrichton
commented
Mar 11, 2017
MemberAuthor
@bors: r=brson |
bors
commented
Mar 11, 2017
Collaborator
📌 Commit f8ca805 has been approved by |
bors
commented
Mar 11, 2017
Collaborator
⌛ Testing commit f8ca805 with merge 244c45b... |
bors
commented
Mar 11, 2017
Collaborator
💔 Test failed - status-travis |
alexcrichton
commented
Mar 11, 2017
via email
MemberAuthor
@bors: retry
* network slowness …On Sat, Mar 11, 2017 at 4:22 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/210138426>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39770 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95AYW1WYtR7EqleSQ6o0rKy3aXKVbks5rkx6QgaJpZM4L-ljs>
.
|
bors
commented
Mar 12, 2017
Collaborator
bors added a commit
that referenced
this pull request
Mar 12, 2017
Delete more swaths of the configure script This PR deletes more swaths of the `./configure` script which are either no longer necessary or already available in rustbuild (where an implementation is preferred)
bors
commented
Mar 12, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
Closed
bjorn3
reviewed
Mar 15, 2017
| elif cputype in {'armv6l', 'armv7l', 'armv8l'}: | ||
| cputype = 'arm' | ||
| ostype += 'eabihf' | ||
| elif cputype == 'armv7l': |
Member
There was a problem hiding this comment.
This cputype is also in the list at new line 472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deletes more swaths of the
./configurescript which are either no longer necessary or already available in rustbuild (where an implementation is preferred)