Uh oh!
There was an error while loading. Please reload this page.
book: don’t use GNU extensions in the example unnecessarily - #39775
Conversation
rust-highfive
commented
Feb 13, 2017
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
GuillaumeGomez
commented
Feb 13, 2017
Seems a bit better this way. Thanks! |
bors
commented
Feb 15, 2017
☔ The latest upstream changes (presumably #39633) made this pull request unmergeable. Please resolve the merge conflicts. |
The use of a GNU C extension for bloc expressions is immaterial to the actual problem with C macros that the section tries to show so don’t use it and instead use a plain C way of writing the macro.
steveklabnik
commented
Feb 15, 2017
@bors: r+ rollup thanks! |
bors
commented
Feb 15, 2017
📌 Commit b6a1618 has been approved by |
book: don’t use GNU extensions in the example unnecessarily The use of a GNU C extension for bloc expressions is immaterial to the actual problem with C macros that the section tries to show so don’t use it and instead use a plain C way of writing the macro which has added benefit of being better C code (since the macro now behaves like a function, syntax-wise).
book: don’t use GNU extensions in the example unnecessarily The use of a GNU C extension for bloc expressions is immaterial to the actual problem with C macros that the section tries to show so don’t use it and instead use a plain C way of writing the macro which has added benefit of being better C code (since the macro now behaves like a function, syntax-wise).
book: don’t use GNU extensions in the example unnecessarily The use of a GNU C extension for bloc expressions is immaterial to the actual problem with C macros that the section tries to show so don’t use it and instead use a plain C way of writing the macro which has added benefit of being better C code (since the macro now behaves like a function, syntax-wise).
The use of a GNU C extension for bloc expressions is immaterial to the
actual problem with C macros that the section tries to show so don’t
use it and instead use a plain C way of writing the macro which has
added benefit of being better C code (since the macro now behaves like
a function, syntax-wise).